FamilySearch tools window: layout, editor context, and link button UX improvements#2
Merged
dsblank merged 4 commits intoJun 11, 2026
Conversation
Move the FS connection status widget from the top of the window to a bottom status bar, giving the active person name full-width prominence. Place the Link FamilySearch ID button directly below the person name, above the notebook tabs. Replace the Person actions FlowBox with three explicit rows: Compare on its own row, Sync from/to on one row, and Export to FamilySearch on its own row. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The tools window kept the person name and buttons active after the Edit Person dialog was closed, because the destroy signal was never handled. Connect to destroy on the editor window and clear _LAST_EDITOR when the tracked editor closes, triggering an immediate UI refresh so the name resets to "(none)" and buttons are disabled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When editing a person who already has an _FSFTID attribute the button now reads "Edit FamilySearch ID". When the person has no _FSFTID the button reads "Add FamilySearch ID" and all other action buttons are disabled until the ID is linked. The FSFTID check reads from the live in-memory editor object so a freshly added ID is detected before it is saved to the database. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The green highlight on the Sync from FamilySearch button gave it unwarranted prominence over the other action buttons. Remove the suggested-action CSS class so it renders as a plain button. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three improvements to the FamilySearch Tools window, built on the existing
pr-2147-fs-loginintegration.1. Reorganize FamilySearch tools window layout
Before:
After:
Moves the FS connection status widget from the top of the window to a
bottom status bar, giving the active person name full-width prominence.
Places the Link FamilySearch ID button directly below the person name,
above the notebook tabs. Replaces the Person actions FlowBox with three
explicit rows: Compare on its own row, Sync from/Sync to on one row, and
Export to FamilySearch on its own row. This gives each action a clear
visual hierarchy and avoids buttons wrapping unpredictably at narrow widths.
2. Clear editor context when Edit Person window is closed
The tools window previously kept the person name and all action buttons
active after the Edit Person dialog was closed, because the window-destroy
signal was never handled. This change connects to
destroyon the editorwindow and clears
_LAST_EDITORwhen the tracked editor closes, triggeringan immediate UI refresh so the name resets to "(none)" and all
person-specific buttons are disabled.
3. Change Link button label and sensitivity based on FSFTID state
When an Edit Person window is open:
_FSFTIDattribute, the button reads"Edit FamilySearch ID" and all other action buttons remain enabled.
_FSFTIDattribute, the button reads"Add FamilySearch ID" and all other action buttons are disabled
until an ID is linked.
The FSFTID check reads from the live in-memory editor object (not the
database copy), so a freshly typed ID is detected immediately — even before
the person is saved.
Test plan
_FSFTIDattribute → Link button shows "Add FamilySearch ID", all other action buttons are disabled_FSFTID→ Link button shows "Edit FamilySearch ID", all other buttons enabled🤖 Generated with Claude Code