docs: stage 2 missing conditional-request field requirements - #140
Merged
Conversation
Following the same investigation as cpp-RCP's equivalent pass: checked the Compound/CompoundWait/Triggered cluster's field-level completeness against TC18 sec 11.2.2 directly, given the pattern of gaps already found in the sibling repos' conditional-request layers. This module's design is notably more complete than cpp-RCP's: it already implements cmp_exec_delay/cmpw_exec_delay (resolve_compound_ exec_delay), trigger_exec_delay (resolve_trigger_exec_delay), and trigger_repetitions (TriggerRepeatCount/is_trigger_repeat_exhausted), all real, well-tested code -- not comment-only like cpp-RCP's equivalents. Two genuine field-level gaps remain, confirmed by grep across src/request.rs (the real TC18 field names appear nowhere outside docs): - Compound/CompoundWait: cmp_repetitions/cmpw_repetitions (repeat count) is absent -- only the exec_delay timer exists, no repeat concept at all for these two kinds specifically. - Triggered: trigger_source_ep/trigger_signal_nr/trigger_threshold are absent -- should_count_trigger_occurrence(endpoint_busy) always returns true regardless of which signal or endpoint fired, so there is no mechanism to specify or check which specific trigger a pending request is actually waiting for, nor an occurrence- threshold gate before first execution. Separately (not staged here, since a requirement already exists and is traced+tested -- this is a defect, not an absence): REQ-TIME-002/ 003's TimedExecutionTime composes AvtpTimestamp (32-bit, ~4.3s rollover) for a Timed request's presentation-time gate. The code's own doc comment is explicit that this was an unconfirmed judgment call, not a verified wire fact. TC18's real presentation_time (sec 11.2.2.5) is 48-bit, gPTP-domain, ~3.25-day rollover -- a materially different value. Flagged in memory for its own fix, not included in this staging file. Per this session's discussion: RELAY spec 20.1.2 hard-gates 100% requirement traceability in CI. Staged in a new .fusa-reqs-pending.json (same schema, confirmed not read by rsfusa), to be migrated into .fusa-reqs.json once each gets a real implementation and test. No code change. rsfusa check/trace unaffected (confirmed, 0 errors). Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmp_exec_delay/cmpw_exec_delay,trigger_exec_delay, andtrigger_repetitionsare all real, well-tested implementations already.cmp_repetitions/cmpw_repetitionsabsent — only the exec_delay timer exists.trigger_source_ep/trigger_signal_nr/trigger_thresholdabsent —should_count_trigger_occurrencealways returns true regardless of which signal/endpoint fired.REQ-TIME-002/003'sTimedExecutionTimecomposes 32-bitAvtpTimestampfor a Timed request's presentation-time gate. The code's own doc comment says this was an unconfirmed judgment call; TC18's realpresentation_time(§11.2.2.5) is 48-bit gPTP-domain. Recorded in memory for its own fix..fusa-reqs-pending.json(same schema, confirmed not read byrsfusa) per this session's discussion — RELAY §20.1.2 hard-gates 100% traceability, so these can't go into.fusa-reqs.jsonwithout either breaking CI or being real. No code change.Test plan
rsfusa check --dir .— 0 errors, unchangedrsfusa trace --dir .— unchanged (only pre-existing HLR/LLR warnings)