fix: v5.0.1 — correct //fusa:req tag whitespace, close 43 req-catalog gaps - #136
Merged
Merged
Conversation
… gaps The //fusa:req///fusa:test tag scanner requires no space after `//`; 1311 annotations across source, fuzz targets, and two safety docs used `// fusa:req` (with a space), so those requirements were silently invisible to fusa-gap-check.sh's coverage accounting despite being correctly implemented and tested. Fixing the tag format surfaced 43 code-side requirement tags with no corresponding entry in .fusa-reqs.json (REQ-ABB-006/007/009, REQ-CAN-012..016, REQ-CMP-009, REQ-CRC-014/017/019, REQ-DISC-025/026, REQ-EPGEN-001, REQ-ERR-021/022, REQ-ERRH-001, REQ-EVT-001/002, REQ-GBB-007, REQ-GPIO-017..021, REQ-I2C-009..011, REQ-ISELED-011, REQ-LIFE-015/019, REQ-LIN-007, REQ-NET-002, REQ-NTSCF-007, REQ-PWMI-003, REQ-RESP-002/003, REQ-RMAP-032/036, REQ-SEQ-005, REQ-TS-007, REQ-WAKE-009); each is now a real catalog entry citing its TC18 source. scripts/fusa-gap-check.sh also gains a status: "not-implemented" exemption path plus a stale_unimpl check, so an entry marked not-implemented that later gains code/test coverage is itself flagged as a gap. No API or wire-format change; PATCH bump per docs/SEMVER.md. 607/607 requirements now traced (100%), verified against the real fusa-gap-check.sh tool, not re-derived from it. Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//fusa:req///fusa:testannotations that used// fusa:req(with a space after//), which the tag scanner requires to have none — these requirements were silently excluded fromfusa-gap-check.sh's coverage accounting despite being correctly implemented and tested..fusa-reqs.json; each is now a real catalog entry with its own TC18 citation (not a stub).scripts/fusa-gap-check.shgains astatus: "not-implemented"exemption path plus astale_unimplcheck (an entry marked not-implemented that later gains code/test coverage is itself flagged as a gap).docs/SEMVER.md.Test plan
cargo build --releasecleancargo test --all-features— 1102 + 32 tests pass, doc-tests passcargo fmt --checkcleancargo clippy --all-targets --all-features -- -D warningscleanbash scripts/fusa-gap-check.sh→ 607/607 (100%) traced, no gaps detected