Fix starting points

[m4rc1e]

I've fixed the interpolation issues in #540 via scripting. @EbenSorkin fonts have been regenned as well.

@kenmcd would you mind reviewing the regenned fonts in this pr?

[Cogli]

Using Merriweather-Italic[opsz,wdth,wght].ttf from this PR, WGHT:900 and WDTH:87 :

Some misplaced anchor, it seems.

Some other glyphs have similar issues, but for different values of WGHT and WDTH, so it will be more difficult to identify the defective master for those.

[m4rc1e]

Thanks @Cogli. I'll checkout a previous commit to see if I haven't introduced this change.

[Cogli]

Thanks @Cogli. I'll checkout a previous commit to see if I haven't introduced this change.

Done! It is not a case of regression, issue already visible in v 2.200

[m4rc1e]

What app/page are you using to check this?

[Cogli]

Screenshot from dinamo font gauntlet.

[kenmcd]

@kenmcd would you mind reviewing the regenned fonts in this pr?

Sure. Will be at my computer in about 3 hours from now. Will do it then.

[kenmcd]

@m4rc1e
The start point issues appear to be resolved for those glyphs I included in #540.
But other issues remain - element order issues and the moving diacritics issues.
Think I can see the source of both those problems.
And can document it with images.

Do you want to have that conversation here?
Or should I make a new v2.300PR issues post?
There are also a few other issues I can see which should be addressed.

[m4rc1e]

Let's keep them in this pr. Makes things it easier to manage!

Thanks for checking! this is gold.

[kenmcd]

OK... "I'll be back."

[Cogli]

I'm sorry, I do not have access to the .glyphs sources, so I can't really be of help in diagnosing or solving the problem. Many thanks to you!

[kenmcd]

These are all for this PR v2.300 Italic

Element Order issue - hungarumlautcomb.case
/Ohungarumlaut/Uhungarumlaut/Uacutedblcyr/hungarumlautcomb.case
Different element order in some of the Light masters
Looks like - Light, LightDisplay, SemiExpandedLightDisplay

/dieresiscombcy.case
Has a width in some masters.

/Lcaron
The caron overlaps the L at minimum opsz (7)

Diacritics offset
As you can see in @Cogli 's post above.
Many different glyphs have big offsets on the diacritic elements.
Mostly appear to be in the various "Black" masters.
If you can filter to find large X offsets, that would find these.
(and probably find some that I missed)

Black7pt master
/abrevegrave/abrevehoi/abrevetilde/acaron/acircumflex/acircumflexacute/acircumflexdotbelow/acircumflexgrave/acircumflexhoi/acircumflextilde/adblgrave/adieresis/agrave/ainvertedbreve/amacron/aring/atilde
/umacroncyr/udieresiscyr/uacutedblcyr

Black144 master
/ccaron/dzcaron/ezhcaron/gcaron/ucaron/zcaron/Dzcaron
/ishortcyr.sc/igravecyr.sc/kjecyr.sc

SemiExpandedBlackSmall master
/zacute/zcaron/zdotaccent

Going to scan the Italic again to see if anything jumps out.
Then going to take another look at the Roman.
IIRC I did not see anything with v2.200, but should check it.

[kenmcd]

Roman v2.300PR - Start Point issues

/dcroat/ordmasculine/Estailcyr/djecyr/yusbigcyr/zero.tf.zero

[kenmcd]

Regarding using tabular figures for a tabular report...
Is there any concern that:
The figurespace (U+2007) width does not match the tabular figures width?
And the punctationspace (U+2008) width does not match either the period or the comma width?

[m4rc1e]

@kenmcd Fantastic review! thank you so much for doing this!

@EbenSorkin I think it may be easier for us to ignore this PR and just make sure that these issues are solved in the African update

[EbenSorkin]

Does the PR fix this or just list the issues? It should be fast to fix a misplaced anchor and to resolve the interpolation issues I see in this thread. If they are not done I am happy to do the fixes today.

…

-e.

On Mon, Jul 17, 2023 at 6:47 AM Marc Foley ***@***.***> wrote: @kenmcd <https://github.com/kenmcd> Fantastic review! thank you so much for doing this! @EbenSorkin <https://github.com/EbenSorkin> I think it may be easier for us to ignore this PR and just make sure that these issues are solved in the African update — Reply to this email directly, view it on GitHub <#557 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQUQXOKGWIIH4NOP6D7KZTXQUJ5ZANCNFSM6AAAAAA2KDXYBU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[m4rc1e]

Does the PR fix this or just list the issues?

This PR only fixes the starting points issues for the Italic and Roman (just done this one now) sources. This has fixed issues such as #557 (comment). It doesn't fix the misplaced Anchors.

Please merge this PR, then fix the anchors. If your git skills are good enough, just add commits to this pr to fix the anchors.