-
Notifications
You must be signed in to change notification settings - Fork 27
Milestone3m [WiP] #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timea-solid
wants to merge
40
commits into
main
Choose a base branch
from
milestone3m
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Milestone3m [WiP] #369
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
e00b513
added preparations for mobile
timea-solid 97728df
cnosolidation of mobile options
timea-solid 323e81c
SolidOS app title
timea-solid 1043c5c
removed old table structure form databrowser.html
timea-solid 0e4918f
removed old table structure form databrowser.html
timea-solid 3a9b087
SolidOS app title
timea-solid 476a36c
cnosolidation of mobile options
timea-solid d294201
some merge issues
timea-solid 4723132
merge main
timea-solid 7d61e49
merge main
timea-solid 5fd8127
Update README.md
timea-solid ec908b9
Update src/styles/mash.css
timea-solid c5ed774
Update src/styles/mash.css
timea-solid 641de88
Update src/styles/mash.css
timea-solid 5a6f721
Update src/index.ts
timea-solid f23652e
fixed header issue
timea-solid a2da363
fixed header issue
timea-solid d579d83
added left side menu to databrowser only
timea-solid 4441a66
updated pane-registry
timea-solid 917fe0b
merge main
timea-solid 81ada6a
updates some css for header
timea-solid 2f9dc1a
added web components and improved header
timea-solid a361f2b
updated package.json
timea-solid 67da899
add new styles and vars
SharonStrats 22e7dd3
needed to save
SharonStrats b8a2995
Fix databrowser shell mounts and environment sync
824349a
Merge branch 'milestone3m' of https://github.com/solidos/mashlib into…
c8231db
npm run build:workspace for linked packages
cb0f338
cleanup
7ca2c38
btn and border styles
SharonStrats 679a830
Merge branch 'milestone3m' of https://github.com/SolidOS/mashlib into…
SharonStrats e57d57e
delete static styles
timea-solid b5a179c
updated to node 24
timea-solid 30c7a74
add gray 500
SharonStrats 36762f4
fix build
timea-solid 7484b43
aligned some css
timea-solid 4221068
font weight medium
SharonStrats 33e6fee
gap xxs
SharonStrats 295b47c
Merge branch 'milestone3m' of https://github.com/SolidOS/mashlib into…
SharonStrats 31b6b9d
color and border md
SharonStrats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -36,10 +36,27 @@ A colorful dependency tree can be seen [here](https://github.com/solidos/solidos | |||||
| - [Solid-ui & Solid-logic related:](#solid-ui--solid-logic-related) | ||||||
| - [The databrowser hack: upgrading your browser](#the-databrowser-hack-upgrading-your-browser) | ||||||
|
|
||||||
| ### [Generative AI usage](#generative-ai-usage) | ||||||
|
|
||||||
| ## Developing mashlib | ||||||
|
|
||||||
| As part of the SolidOS stack, mashlib can be developed locally by setting up the SolidOS code. Read more about that on the [SolidOS Readme](https://github.com/solidos/solidos#-getting-started-with-the-solidos-code). | ||||||
|
|
||||||
| ### Webpack Resolution Modes | ||||||
|
|
||||||
| Mashlib webpack now supports two explicit resolution modes: | ||||||
|
|
||||||
| - `package` mode: default. Resolves `solid-ui` and `solid-panes` from `node_modules`, which is the correct behavior for npm installs and published builds. | ||||||
| - `workspace` mode: opt-in. Resolves selected SolidOS packages from sibling workspace source trees for local linked development. | ||||||
|
|
||||||
| Use these scripts for local workspace builds: | ||||||
|
|
||||||
| - `npm run build:workspace` | ||||||
| - `npm run watch:workspace` | ||||||
| - `npm run start:workspace` | ||||||
|
|
||||||
| `npm run build`, `npm run watch`, and `npm run start` stay on default package resolution. | ||||||
|
|
||||||
| ## Goals | ||||||
|
|
||||||
| The goals of mashlib overlap with the [SolidOS Goals](https://solidos.solidcommunity.net/Team/docs/SolidOSNorthStar.html). | ||||||
|
|
@@ -151,3 +168,13 @@ The mashlib part of SolidOS Databrowser Frontend is *read-write;* that is, the u | |||||
|
|
||||||
| A major limitation of this data browser hack is that current web browsers are made to distrust any code loaded from one domain that uses data from another domain. This makes it hard, strangely complicated, and sometimes impossible to do some things. | ||||||
|
|
||||||
| ## Generative AI usage | ||||||
| The SolidOS team is using GitHub Copilot integrated in Visual Studio Code. | ||||||
| We have added comments in the code to make it explicit which parts are 100% written by AI. | ||||||
|
|
||||||
| ### Prompt usage history: | ||||||
| * Auto model: Looking at these 2 files (databrowser.html and index.ts), I want to redesign mashlib and underlying panes. I have a design for web and one for mobile. How would I go about making sure I can also have a mobile version? | ||||||
|
|
||||||
| * Claude-Opes 4.6: I don't think this is correct. Mashlib is bundling together all the panes. I do not need to add mashlib.layout or theme to the globals. I can just call the render of each pane with an interface of values or? | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| * Raptor mini: I want to rdesign the main page which contains GlobalDashboard and OtlineView. I keep the header and footer and I want to have a left side menu that chnages content base on logged in or not and also chnages if it is mobile or not. If it is mobile it should fold up in the header menu if it is web it should be rendered on the left side. I want a menu placeholder that changes according to mobile or not. Its functionality I want to implement in solid-panes. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.