-
-
Notifications
You must be signed in to change notification settings - Fork 2
Test suite #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Test suite #17
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9679721
.
1ab3e68
set-up a comprehensive test-suite for all apipod features including d…
f804692
added pull-request clause for CI
b83ef3d
changed verbosity level of pytest in github workflows
4549964
fixed a bug ocurring due to the new async generator check that goes d…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| # Development instructions | ||
|
|
||
| ## 1. Think Before Coding | ||
|
|
||
| **Don't assume. Don't hide confusion. Surface tradeoffs.** | ||
|
|
||
| Before implementing: | ||
| - State your assumptions explicitly. If uncertain, ask. | ||
| - If multiple interpretations exist, present them. Don't pick silently. | ||
| - If a simpler approach exists, say so. Push back when warranted. | ||
| - If something is unclear, stop. Name what's confusing. Ask. | ||
| - Use thinking methods like Elon Musk's first principle reasoning or design-thinking for complex tasks. | ||
|
|
||
| ## 2. Simplicity First | ||
|
|
||
| **Minimum code that solves the problem. Nothing speculative.** | ||
| - No features beyond what was asked. | ||
| - No abstractions for single-use code. | ||
| - No "flexibility" or "configurability" that wasn't requested. | ||
| - No error handling for impossible scenarios. | ||
| - If you write 200 lines and it could be 50, rewrite it. | ||
| - Don't repeat yourself. | ||
|
|
||
| Ask yourself: "Would a senior engineer say this is overcomplicated?" If yes, simplify. | ||
|
|
||
| ## 3. Surgical Changes | ||
|
|
||
| **Touch only what you must. Clean up only your own mess.** | ||
|
|
||
| When editing existing code: | ||
| - Don't "improve" adjacent code, comments, or formatting. | ||
| - Match existing style, even if you'd do it differently. | ||
| - If you notice unrelated dead code, mention it - don't delete it. | ||
|
|
||
| When your changes create orphans: | ||
| - Remove imports/variables/functions that YOUR changes made unused. | ||
| - Don't remove pre-existing dead code unless asked. | ||
|
|
||
| The test: Every changed line should trace directly to the user's request. | ||
|
|
||
| ## 4. Code quality and style | ||
| - Write high-quality, developer-friendly and clean-code, use design-patterns (Refactoring Guru) where helpful. | ||
| - Include docstrings and comments to explain the why of a non-obvious method or code. No decorative comments. | ||
| - Write memory and compute efficient code. | ||
| - Write pythonic code and use builtins when it simplifies (generators, list-comprehensions, functools). | ||
| - Reduce complexity and boilerplate. Remove unused code. | ||
| - State unclear variable names and rename for better readability and clearity. | ||
| - Avoid local imports | ||
| - Do not write "deprecated" or backward compability code. | ||
| - Update the README.md if there's user related important changes. Update TECHNICAL_README.md for architectural, or project maintainer important changes. Keep the .md update brief use technical correct terms. | ||
| - Write flake8 formatted code with "flake8.args": [ | ||
| "--max-line-length=120", | ||
| "--ignore=E203,W503,E501,E261,W293" | ||
| ] | ||
| } | ||
| - Avoid using direct cmd python calls and pip installs. Work with the local venv if necessary. Always ask if necessary. | ||
|
|
||
| ## 5. Reason and thinking style | ||
| Do thinking and reasoning like a smart caveman. | ||
| - Cut all filler, keep technical substance. | ||
| - Drop articles (a, an, the), filler (just, really, basically, actually). | ||
| - Drop pleasantries (sure, certainly, happy to). | ||
| - No hedging. Fragments fine. Short synonyms. | ||
| - Technical terms stay exact. Code blocks unchanged. | ||
| - Pattern: [thing] [action] [reason]. [next step] | ||
|
|
||
| ## 6. Public facing texts: Readmes, prints, logs. | ||
| - Write as technically brilliant European expert who gives you straight answers, backs claims with data, and genuinely wants you to succeed. | ||
| - Ttone spectrum Formality 35% (lean casual) · Humor 25% (dry, never flippant) · Complexity 40% (lean technical) · Confidence 80% (very confident). | ||
| - Direct without being cold. Say what you mean, no corporate padding. Warm without being informal. Complete sentences, measured enthusiasm. Committed, not hedging. | ||
| - Committed, not hedging. "This works", not "this might work". | ||
| - "We" for the platform, "you" for the reader. Reserve "I" for rare authored guides only. | ||
| - Developer-first, technical correct terms. | ||
| - No em-dashes. The character `—` (U+2014) must not appear in ANYWHERE. Use a period, comma, parentheses, or colon. | ||
| - No marketing adverbs like seamlessly, effortlessly, robust, powerful, cutting-edge, automatically, intelligently, revolutionary, game-changing, world-class, best-in-class. E.g. three steps, ~X minutes" beats "easy onboarding". | ||
| - No bullet-everything. Bullets only for true enumerations (statuses, regions, tiers). | ||
| - Subtle transmit socaity's vision and use emotional-intelligence and marketing techniques for end-user intent based messages. | ||
| - Use google docstring format. | ||
| - The four brand hues (each tied to an ICP) with Tonal scales (50/300/500/700/900). Apply where makes sense. | ||
| | Name | Hex | Meaning / ICP | | ||
| | ---------------------------- | ----------- | ------------------------------------------------------------------------- | | ||
| | **Neon Green** | `#5A8F00` | Developer. Active system health, engineering precision, technical truth. | | ||
| | **Silicon Blue** | `#0A86BF` | SMB CTO. Enterprise stability, secure infrastructure, professional trust. | | ||
| | **Creator Violet** | `#7C3AED` | Creator. Generative potential, creative momentum, warmth. | | ||
| | **Signal Pink (Rose)** | `#EC4899` | Alert. Warnings, critical status, high-priority attention. | | ||
|
|
||
|
|
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay, we can start using soft requirements, we move to strict when we have applied this across the repos.