SMOODEV-2498: add bounded connect timeout to smooai-fetch#88
Open
brentrager wants to merge 1 commit into
Open
Conversation
api-prime's ~16s API stalls (SMOODEV-2481) were fresh SYNs black-holing to dead pod IPs still lingering in a ClusterIP's iptables (endpoint-removal race). smooai-fetch builds a fresh reqwest::Client per request/retry but set no connect timeout, so reqwest waited the full whole-request timeout (15s) before the retry could land on a live pod. Add FetchBuilder::with_connect_timeout(ms) (and FetchOptions.connect_timeout_ms, default None so existing consumers are unchanged). When set, do_single_request builds the client via reqwest::Client::builder().connect_timeout(...); when unset the path is behaviorally identical (reqwest::Client::new()). A bounded connect timeout fails a black-holed connect in ~the configured window while slow-but-alive handlers (whole-request timeout) are untouched. Covered by tests/connect_timeout_tests.rs: a connect to a non-routable IP returns a request error in ~the connect window (~0.5s) rather than hanging to the whole-request timeout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
api-prime's ~16s API stalls (SMOODEV-2481) traced to fresh SYNs black-holing to dead pod IPs still lingering in a ClusterIP's iptables during an endpoint-removal race.
smooai-fetchbuilds a freshreqwest::Clientper request/retry (so there is no stale keepalive to fix) but set no connect timeout — so reqwest waited the full whole-request timeout (15s in api-prime) before the existing retry could land on a live pod.Fix
Add a bounded connect timeout so a black-holed connect fails in ~the configured window and the existing retry lands on a live endpoint, while slow-but-alive handlers (governed by the whole-request timeout) are untouched.
FetchBuilder::with_connect_timeout(ms)— mirrorswith_timeout.FetchOptions.connect_timeout_ms: Option<u64>— defaultNone, so existing consumers are behaviorally unchanged.do_single_requestbuilds viareqwest::Client::builder().connect_timeout(Duration::from_millis(ms)).build()?when set; falls back to the identicalreqwest::Client::new()path when unset.Test
tests/connect_timeout_tests.rs: a connect to a non-routable/black-hole IP (10.255.255.1:80) with a 500ms connect timeout and a 5s whole-request timeout returns aFetchError::Requestin ~0.5s (asserted< 3s) instead of hanging to the whole timeout. Full suite green (cargo test -p smooai-fetch --locked: 111 passed), fmt + clippy clean.🤖 Generated with Claude Code