Fix neo 21.1.237 Issue #110 - #111
Open
TI7AN wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In update 21.1.237 neoforge added missing throw statements to the registry that were previously failing silently.
The previous implementation for the armor material used a supplier which was called a total of 5 times, resulting in the second attempt at a registration triggering the throw.
I also added some new "ForHolder" variants of the register functions in RegistryHelper since armor equip sound registration needed to be updated because (for some reason) armor equip sounds seem to be registered with Registry.registerForHolder instead of the usual register function (view vanilla SoundEvents).