test: Expand upload tests with fake_forge#250
Open
jerry-skydio wants to merge 1 commit into
Open
Conversation
Now that we have a forge abstraction, we can improve test coverage in upload. Add a fake forge class that tracks query / update data in memory and a bunch of tests that exercise the various flags.
Collaborator
Author
Collaborator
Author
|
This was referenced May 20, 2026
48d65d5 to
0c04e95
Compare
bd7abad to
9828716
Compare
d68e6ac to
4599c0b
Compare
This was referenced May 21, 2026
brian-kubisiak-skydio
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a forge abstraction, we can improve
test coverage in upload. Add a fake forge class that
tracks query / update data in memory and a bunch of
tests that exercise the various flags.