Skip to content

Fix keybind capture - #5

Merged
jensonhirst merged 2 commits into
SiriusSoftwareLtd:requestfrom
Razr7315:request
Aug 19, 2026
Merged

Fix keybind capture#5
jensonhirst merged 2 commits into
SiriusSoftwareLtd:requestfrom
Razr7315:request

Conversation

@Razr7315

Copy link
Copy Markdown
Contributor

The keybind field was clearing its value as soon as it was focused, so it saved nil when the click didn’t register as a valid key input. It now keeps the previous bind unless a valid key is selected, and mouse clicks no longer trigger bound actions.

maxtcodes

This comment was marked as duplicate.

@maxtcodes maxtcodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one issue that should be fixed before merging.

The new keybind capture flow retains the old bind when focus is lost, but it also removes the only way to clear an assigned keybind and return it to "No Keybind."

The rest of the keybind changes look consistent, and CI is passing. Once users can clear an assigned bind without reintroducing the accidental clear bug, I think this will be ready for Jenson to review and merge.

Requesting changes for the inline issue above.

Preserve assigned keybinds when capture loses focus, while allowing
Backspace/Delete to intentionally clear them to No Keybind.
@Razr7315

Copy link
Copy Markdown
Contributor Author

Fixed. Losing focus now cancels key capture and restores the previous bind, while pressing Backspace or Delete sets it to “No Keybind.”

@jensonhirst
jensonhirst merged commit 2501db9 into SiriusSoftwareLtd:request Aug 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants