Fix keybind capture - #5
Merged
Merged
Conversation
maxtcodes
requested changes
Aug 12, 2026
Member
There was a problem hiding this comment.
I found one issue that should be fixed before merging.
The new keybind capture flow retains the old bind when focus is lost, but it also removes the only way to clear an assigned keybind and return it to "No Keybind."
The rest of the keybind changes look consistent, and CI is passing. Once users can clear an assigned bind without reintroducing the accidental clear bug, I think this will be ready for Jenson to review and merge.
Requesting changes for the inline issue above.
Preserve assigned keybinds when capture loses focus, while allowing Backspace/Delete to intentionally clear them to No Keybind.
Contributor
Author
|
Fixed. Losing focus now cancels key capture and restores the previous bind, while pressing Backspace or Delete sets it to “No Keybind.” |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keybind field was clearing its value as soon as it was focused, so it saved nil when the click didn’t register as a valid key input. It now keeps the previous bind unless a valid key is selected, and mouse clicks no longer trigger bound actions.