Skip to content
This repository was archived by the owner on Dec 30, 2024. It is now read-only.

Generic's Generic planet lobby BG - #88

Open
SomewhatSad14 wants to merge 8 commits into
Simple-Station:masterfrom
SomewhatSad14:Planets.Lobby
Open

Generic's Generic planet lobby BG#88
SomewhatSad14 wants to merge 8 commits into
Simple-Station:masterfrom
SomewhatSad14:Planets.Lobby

Conversation

@SomewhatSad14

@SomewhatSad14 SomewhatSad14 commented Apr 11, 2023 •
edited by DEATHB4DEFEAT
Loading

Copy link
Copy Markdown

Description

A new lobby background with planets in the shape of the big/little dipper.

Changelog

🆑 Generic

  • add: Added planets lobby screen was added
  • tweak: Froze earth

@github-actions github-actions Bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Apr 11, 2023
DEATHB4DEFEAT
DEATHB4DEFEAT approved these changes Apr 11, 2023
View reviewed changes
Comment thread Resources/Prototypes/lobbyscreens.yml
Comment thread Resources/Textures/LobbyScreens/attributions.yml Outdated
Pspritechologist
Pspritechologist suggested changes Apr 13, 2023
View reviewed changes

@Pspritechologist Pspritechologist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mentioned about the file name. Other than that, looks good to me.

Comment thread Resources/Prototypes/lobbyscreens.yml
@Pspritechologist

Pspritechologist commented Apr 13, 2023

Copy link
Copy Markdown
Member

You should edit the PR name and description to uh
Be something :P

@DEATHB4DEFEAT DEATHB4DEFEAT added the Status: Awaiting Changes Do not merge due to requested changes label Apr 26, 2023
@github-actions github-actions Bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Apr 30, 2023
@github-actions

github-actions Bot commented Apr 30, 2023

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@SomewhatSad14 SomewhatSad14 changed the title Planets.LobbyBG Generic's Generic planet lobby BG May 7, 2023
SomewhatSad14 and others added 2 commits May 7, 2023 02:06
@SomewhatSad14
YML Updated
3b5dd4b 
Changed Planets to - Dipper, because the planets make the Ursa major? constellation (might be Ursa minor)
@SomewhatSad14 @DEATHB4DEFEAT
Apply suggestions from code review
2fbda27 
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
@github-actions github-actions Bot removed the Status: Awaiting Changes Do not merge due to requested changes label May 7, 2023
Pspritechologist
Pspritechologist suggested changes May 11, 2023
View reviewed changes
Comment thread Resources/Textures/LobbyScreens/attributions.yml Outdated
@Pspritechologist

Pspritechologist commented May 11, 2023

Copy link
Copy Markdown
Member

Edit the PR description to be something basic, it gets saved in the commit history.

@SomewhatSad14 @Pspritechologist
Update Resources/Textures/LobbyScreens/attributions.yml
760e43f 
Co-authored-by: Pspritechologist <81725545+Pspritechologist@users.noreply.github.com>
@Pspritechologist

Pspritechologist commented May 20, 2023

Copy link
Copy Markdown
Member

Don't merge this until the pr description is like, anything. A changelog isn't needed, a checklist isn't needed, but just state what it does, please.

@DEATHB4DEFEAT

DEATHB4DEFEAT commented May 20, 2023

Copy link
Copy Markdown
Member

Don't merge this until the pr description is like, anything. A changelog isn't needed, a checklist isn't needed, but just state what it does, please.

you have permission to edit it

@DEATHB4DEFEAT

DEATHB4DEFEAT commented May 20, 2023

Copy link
Copy Markdown
Member

image

@Pspritechologist

Pspritechologist commented May 20, 2023

Copy link
Copy Markdown
Member

Don't merge this until the pr description is like, anything. A changelog isn't needed, a checklist isn't needed, but just state what it does, please.

you have permission to edit it

I am well aware.

@github-actions github-actions Bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label May 21, 2023
@github-actions github-actions Bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Jul 23, 2023
@github-actions

github-actions Bot commented Jul 23, 2023

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before we can evaluate the pull request.

DEATHB4DEFEAT
DEATHB4DEFEAT suggested changes Aug 27, 2023
View reviewed changes
Comment thread Resources/Textures/LobbyScreens/attributions.yml Outdated
Comment thread Resources/Textures/LobbyScreens/attributions.yml Outdated
@SomewhatSad14 @DEATHB4DEFEAT
Update Resources/Textures/LobbyScreens/attributions.yml
3a16cc2 
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
@SomewhatSad14 @DEATHB4DEFEAT
Update Resources/Textures/LobbyScreens/attributions.yml
8f3a211 
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@DEATHB4DEFEAT DEATHB4DEFEAT DEATHB4DEFEAT requested changes
@Pspritechologist Pspritechologist Pspritechologist approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Changes: YML Changes any yml files Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Review Someone please review this

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SomewhatSad14 @Pspritechologist @DEATHB4DEFEAT