Skip to content

Fix CI: eliminate duplicate runs and automate test DB schema #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonOneNineEight merged 6 commits into from
Mar 20, 2026
Merged

Fix CI: eliminate duplicate runs and automate test DB schema #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
025659a
Fix CI: scope push trigger to main and use migration files for test DB
SimonOneNineEight Mar 13, 2026
269d7a2
Merge branch 'main' into epic-9/bug-fixes-workflow-stability
SimonOneNineEight Mar 16, 2026
4159c25
Separate test infrastructure into docker-compose.test.yml
Mar 16, 2026
e7ba408
Redirect www to non-www to fix CORS origin mismatch
Mar 20, 2026
3e1c781
Fix failing tests: time format assertion and unique constraint conflict
Mar 20, 2026
b7ead6e
Fix SoftDeleteInterviewNote test: use isolated interview to avoid uni…
Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: CI

on:
push:
branches: [main]
pull_request:

concurrency:
Expand Down
6 changes: 5 additions & 1 deletion Caddyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{$DOMAIN:localhost}, www.{$DOMAIN:localhost} {
www.{$DOMAIN:localhost} {
redir https://{$DOMAIN}{uri} permanent

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect target uses {$DOMAIN} without a default, while the site labels use {$DOMAIN:localhost}. If DOMAIN is unset, this will generate an invalid redirect URL (e.g., https://{uri}). Use the same default placeholder (or a request placeholder like {host}) in the redirect target to keep behavior consistent when DOMAIN isn’t provided.

Suggested change
redir https://{$DOMAIN}{uri} permanent
redir https://{$DOMAIN:localhost}{uri} permanent

Copilot uses AI. Check for mistakes.
}

{$DOMAIN:localhost} {
encode gzip

header {
Expand Down
2 changes: 1 addition & 1 deletion backend/internal/handlers/interview_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ func TestInterviewHandler(t *testing.T) {
data := resp["data"].(map[string]interface{})
interview := data["interview"].(map[string]interface{})
assert.Equal(t, "technical", interview["interview_type"])
assert.Equal(t, newTime, interview["scheduled_time"])
assert.Contains(t, interview["scheduled_time"], newTime)
assert.Equal(t, float64(newDuration), interview["duration_minutes"])
assert.Equal(t, newOutcome, interview["outcome"])
assert.Equal(t, newFeeling, interview["overall_feeling"])
Expand Down
11 changes: 10 additions & 1 deletion backend/internal/repository/interview_note_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,18 @@ func TestInterviewNoteRepository(t *testing.T) {
})

t.Run("SoftDeleteInterviewNote", func(t *testing.T) {
deleteIv := &models.Interview{
UserID: testUser.ID,
ApplicationID: createdApp.ID,
ScheduledDate: futureDate,
InterviewType: models.InterviewTypeBehavioral,
}
isolatedDeleteIv, err := interviewRepo.CreateInterview(deleteIv)
require.NoError(t, err)

content := "Delete me"
note := &models.InterviewNote{
InterviewID: createdInterview.ID,
InterviewID: isolatedDeleteIv.ID,
NoteType: models.NoteTypeGeneral,
Content: &content,
}
Expand Down
Loading
Loading