Don't allow entry of non-recognised species#6
Draft
svenddpc wants to merge 10 commits into
Draft
Conversation
This fixes an issue where an answer is rated as wrong if it has whitespace on either end. This happens when entering words on a mobile using auto-complete.
…ers that are in the list.
…me. Use the return type constants properly instead of a mix of bools and InvalidAnswer.
Because got_it_right is now an int and "correct" is 0, but got_it_right was being evaluated as a bool, 0 would evaluate to false. Now it's correctly comparing to constant value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking if entered answers are correct, first check if the entered value is a species at all. If not, show a text explaining that it is not a species. This avoids failing people for spelling, odd spaces, etc.
Null is treated as a "wrong answer", rather than an incorrect answer, however, it is not possible to submit null, only "", which is currently treated as an invalid answer, so if that isn't changed, maybe we'd need a "give up" or "skip" button, instead of having to enter some random species if you have no idea (and not just "pigeon") :P
A better solution would possibly be to use the set of names (in all_bird_names.json) for an autocomple feature when entering text. I might give this a go at some point, if I find the time:
https://www.w3schools.com/howto/howto_js_autocomplete.asp