feat(grammar): W17B vocabulary extension from PWI+waves absorbed-power evidence#12
Open
Simon-McIntosh wants to merge 1 commit into
Open
feat(grammar): W17B vocabulary extension from PWI+waves absorbed-power evidence#12Simon-McIntosh wants to merge 1 commit into
Simon-McIntosh wants to merge 1 commit into
Conversation
Add 3 physical_base tokens from imas-codex W17B mining of low-scoring
standard names (reviewer_score_name < 0.55, N=86 total analyzed):
absorbed_wave_power N=4 fast_electron, thermal_ion, fast_ion,
thermal_electron _absorbed_wave_power_*
wave_absorbed_power_density N=5 wave_absorbed_power_density_per_toroidal_mode
+ 4 species variants
wave_absorbed_power_inside_flux_surface N=3 fast_ion, thermal_electron,
thermal_ion _...
All three tokens meet the N>=3 evidence gate (policy: commit 1982016).
Placement is alphabetical; comments cite source wave and evidence count.
parallel to wave_driven_absorbed_power_inside_flux_surface already in vocab.
VocabGap nodes in imas-codex graph: 0 (no VocabGap nodes exist yet; tokens
identified by manual parsing of low-score SN compound physical_base strings).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 3 physical_base tokens from imas-codex W17B mining of low-scoring standard names
(
reviewer_score_name < 0.55, N=86 total analyzed, 0 VocabGap graph nodes — tokensidentified by manual parsing of compound
physical_baseresidues).Source: imas-codex W17B wave-heating + PWI campaign synthesis.
Evidence gate: N ≥ 3 distinct names (policy: commit
1982016).Branch:
w17b-vocab-extensionfrommain(does not touch PR #11'svocab-rotation-wave7-wave9branch).Evidence for new vocabulary tokens
Tokens proposed
absorbed_wave_powerphysical_bases.ymlfast_electron_absorbed_wave_power_per_toroidal_mode,thermal_ion_absorbed_wave_power_per_toroidal_mode,fast_ion_absorbed_wave_power_per_toroidal_mode,thermal_electron_absorbed_wave_power_per_toroidal_modewave_absorbed_power_densityphysical_bases.ymlwave_absorbed_power_density_per_toroidal_mode,fast_electron_wave_absorbed_power_density_per_toroidal_mode,thermal_electron_wave_absorbed_power_density_per_toroidal_mode,fast_ion_wave_absorbed_power_density_per_toroidal_mode,thermal_ion_wave_absorbed_power_density_per_toroidal_modewave_absorbed_power_inside_flux_surfacephysical_bases.ymlfast_ion_wave_absorbed_power_inside_flux_surface_per_toroidal_mode,thermal_electron_wave_absorbed_power_inside_flux_surface_per_toroidal_mode,thermal_ion_wave_absorbed_power_inside_flux_surface_per_toroidal_modeEvidence gathered from imas-codex VocabGap analysis: parsing 86 low-scoring SNs
(
reviewer_score_name < 0.55) and extracting unrecognisedphysical_baseresiduestrings. N counts number of distinct low-scoring names that produce the given
unrecognised residue when the known subject prefix is stripped.
Why existing tokens do not suffice
absorbed_wave_power:wave_absorbed_powerexists in ISN (canonical word order), but the imas-codex pipeline generates names withabsorbed_wave_powerword order (adjective-noun vs noun-adjective). This token is the evidence-backed variant form needed to satisfy the open-fallback validator.wave_absorbed_power_density:wave_absorbed_powercovers volumetric power integrals;wave_absorbed_power_density(W·m⁻³) is the distinct volumetric density form absent from the vocabulary. Five species variants (fast_electron, thermal_electron, fast_ion, thermal_ion, plus bare) all require it.wave_absorbed_power_inside_flux_surface: Parallel to the already-presentwave_driven_absorbed_power_inside_flux_surface. Three species-qualified names need the base concept of absorbed wave power cumulated inside a flux surface (W), distinguished from thewave_driven_(current-drive context) and the_density(W·m⁻³) variants.Tokens explicitly rejected (preposition-form ban)
per_toroidal_mode(postfix)per_toroidal_modeis defined asunary_prefixwith test coverage (test_d5_vocabulary.py::test_per_toroidal_mode_power_round_trip). Postfix usage in corpus names is a name-generation bug in imas-codex, not a vocabulary gap.inside_flux_surfaceas prepositioninsideis a locative preposition; ISN only allowsof/at/overlocus relations.per_style postfixes_per_is a preposition).Tokens deferred (N < 3)
wave_powerfast_electron_wave_power_inside_flux_surface_per_toroidal_mode— just one name.peak_power_fluxpeak_power_flux_of_inner_divertor_target+ outer — just misses gate.count_rateminimum_count_rate_of_neutron_detector_mode+ maximum — just misses gate.bidirectional_reflectance_distribution_functionincident_anglesputtering_physical_coefficient_incident_angle.sputtering_angle_of_incidencealready in vocab; rename preferred.vessel_annular_outer_outline_pointvessel_outline_pointalready in locus_registry (PR #11).logarithmic_density_gradientnormalized_logarithmic_density_gradient.Mining summary
physical_baseresidues extracted (after subject/locus stripping)per_toroidal_modeprefix→postfix would breaktest_d5_vocabulary.py)Changes
imas_standard_names/grammar/vocabularies/physical_bases.yml— addabsorbed_wave_power,wave_absorbed_power_density,wave_absorbed_power_inside_flux_surfaceimas_standard_names/schemas/entry_schema.json— schema-version string bump (auto-generated)Testing
1108 passed, 68 xfailed, 0 failed)Checklist
main, does not conflict with PR feat(vocab): add evidence-gated tokens from imas-codex rotation waves 7 and 9 #11 (vocab-rotation-wave7-wave9)