fix: resolve #1674 — When reading is the default mode for new tabs and you create a new note from a Base configured create a file in a folder, the folder template does not fully trigger#1745
Open
andoan16 wants to merge 1 commit into
Conversation
… new tabs and you create a new note from a Base configured create a file in a folder, the folder template does not fully trigger Fixes SilentVoid13#1674 Signed-off-by: Ân Đoàn <33853760+andoan16@users.noreply.github.com>
Zachatoo
requested changes
Jun 2, 2026
Zachatoo
left a comment
Zachatoo
left a comment
Collaborator
There was a problem hiding this comment.
Please add wdio tests, as per the contributing guide. Thanks!
Comment on lines
+75
to
+80
| setTimeout(() => { | ||
| void this.plugin.templater.create_new_note_from_template( | ||
| item, | ||
| this.creation_folder, | ||
| ); | ||
| }, 100); |
Collaborator
There was a problem hiding this comment.
This isn't going to work, there is no editor available in reading mode, ever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #1674 — When reading is the default mode for new tabs and you create a new note from a Base configured create a file in a folder, the folder template does not fully trigger
Problem
Severity:
Medium| File:src/handlers/FuzzySuggester.tsSince the issue occurs when creating new notes through Base/folder creation, the fuzzy suggester logic may need to ensure proper template execution context, especially on mobile devices with reading view defaults.
Solution
Review the folder template triggering logic in the fuzzy suggester to ensure it properly handles the mobile reading view scenario and waits for complete editor initialization before template execution.
Changes
src/handlers/FuzzySuggester.ts(modified)Testing