Skip to content

perf: reduce repeated RSS parsing work #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarthakagrawal927 merged 4 commits into from
Aug 12, 2026
+13 −7
Merged

perf: reduce repeated RSS parsing work #44

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b6cd32
perf: avoid sanitizing plain RSS metadata
sarthakagrawal927 Aug 9, 2026
93bf33e
feat: expose read-only ChatGPT data
sarthakagrawal927 Aug 10, 2026
bda955e
perf: reduce repeated RSS parsing work
sarthakagrawal927 Aug 12, 2026
482e315
Merge remote-tracking branch 'origin/main' into agent/optimize-rss-pa…
sarthakagrawal927 Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/lib/rss-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const MAX_OPML_BYTES = 1_000_000;
export const MAX_FEED_BYTES = 2_000_000;
const MAX_OPML_FEEDS = 500;
const MAX_FEED_ENTRIES = 200;
const DOM_PARSER = new DOMParser();

export interface OpmlSubscription {
title: string;
Expand Down Expand Up @@ -34,10 +35,11 @@ function byteLength(value: string): number {

function cleanText(value: string | null | undefined, maxLength = 2_000): string {
const sanitized = sanitizeHtml(value ?? '', { allowedTags: [], allowedAttributes: {} });
const document = new DOMParser().parseFromString(
`<html><body>${sanitized}</body></html>`,
'text/html'
);
return textFromSanitizedHtml(sanitized, maxLength);
}

function textFromSanitizedHtml(value: string, maxLength: number): string {
const document = DOM_PARSER.parseFromString(`<html><body>${value}</body></html>`, 'text/html');
return (document.body.textContent ?? '').replace(/\s+/g, ' ').trim().slice(0, maxLength);
}

Expand Down Expand Up @@ -98,14 +100,18 @@ export function createEntryExternalId(parts: {
title: string;
publishedAt?: Date;
}): string {
const explicitId = cleanText(parts.id, 1_000);
const rawId = parts.id ?? '';
const explicitId =
rawId.includes('<') || rawId.includes('&')
? cleanText(rawId, 1_000)
: rawId.replace(/\s+/g, ' ').trim().slice(0, 1_000);
if (explicitId) return explicitId;
const identity = [parts.url ?? '', parts.title, parts.publishedAt?.toISOString() ?? ''].join('|');
return `generated:${stableHash(identity)}`;
}

function parseXml(xml: string) {
const document = new DOMParser().parseFromString(xml, 'text/xml');
const document = DOM_PARSER.parseFromString(xml, 'text/xml');
if (!document?.documentElement) throw new Error('Malformed XML document');
return document;
}
Expand Down Expand Up @@ -172,7 +178,7 @@ function normalizeEntry(element: Element, atom: boolean): NormalizedFeedEntry |
atom ? ['content', 'summary'] : ['content:encoded', 'description']
);
const content = cleanHtml(rawContent);
const excerpt = cleanText(rawContent, 500) || undefined;
const excerpt = content ? textFromSanitizedHtml(content, 500) || undefined : undefined;
const publishedAt = parseDate(
firstRawText(element, atom ? ['published', 'updated'] : ['pubDate', 'dc:date', 'date'])
);
Expand Down