ci: declare contents:read on CI Typescript workflow#491
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
The Build Typescript job runs pnpm install + builds inside lang/typescript. No GitHub API write beyond actions/checkout. contents:read is the floor. Style matches the per-job permissions block in npm-release.yml (id-token:write + contents:write + pull-requests:write for the release path). Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CI Typescriptworkflow's singlebuildjob runspnpm install+ the build script insidelang/typescript. No GitHub API write, no cache directive, no comment-on-PR step.This patch pins it to
permissions: contents: readat workflow scope. Style matches the per-job permission block already declared innpm-release.yml(id-token: write+contents: write+pull-requests: writefor the npm publish path).With explicit scope:
Token-Permissionscheck passes for this filepnpm/action-setup,actions/setup-node) is bounded to readci.ymlis the other workflow without an explicitpermissions:block, but it usesruby/setup-rubywithbundler-cache: true, which interacts with the cache-save path and deserves a separate look.No behavioural change.