Ensure runtime server exits after shutdown#708
Merged
Conversation
49158cd to
eae4fb8
Compare
st0012
approved these changes
May 1, 2026
eae4fb8 to
86df70f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A lot of our life cycle was getting really clunky and we are frequently seeing tests hang, especially on Windows. This PR aims to improve the situation:
jointhe boot thread when deactivating the add-on. This one is mostly about tests. Tests quickly create new add-on instances, which boots the Rails app. If we don't join the boot thread, we risk finishing the tests before the Rails app is up and we may end up with orphaned processesforce_killapproach. This was basically a brute force way of trying to ensure things were shutting down properlyexit!(0)once the main loop finishes, to terminate child processes with it