Skip to content

Feature/add group block#73

Open
Rivka-Development wants to merge 235 commits intoShopify:mainfrom
Rivka-Development:feature/add-group-block-id
Open

Feature/add group block#73
Rivka-Development wants to merge 235 commits intoShopify:mainfrom
Rivka-Development:feature/add-group-block-id

Conversation

@Rivka-Development
Copy link
Copy Markdown

No description provided.

Sergio Tamayo and others added 30 commits March 16, 2026 12:09
Perf: Make scroll event listeners passive
Perf: Defer predictive-search.js loading
…-LCP

Optimize responsive images, LCP priority, and deferred mobile hydration
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
- Added Metroflex fonts to the assets and declared them in base.css so they can be used dynamically.

- Overrode the italic tags in the announcement bar section to render as a border underline instead of italics, bypassing the visual editor's lack of an underline button.
feat: Add Metroflex fonts & announcement bar underline
feat: global font variables to use Metroflex site-wide
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
shopify Bot and others added 26 commits April 14, 2026 12:17
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
Committed from shop: Develoment-theme
@Rivka-Development Rivka-Development force-pushed the feature/add-group-block-id branch from 4cc1c8d to 11b5f12 Compare April 14, 2026 14:40
@hubbvee
Copy link
Copy Markdown

hubbvee commented Apr 16, 2026

Code review

Found 4 issues:

  1. deferred-hydration.js checks hasAttribute('mobile-only'), but every Liquid caller uses data-mobile-only="true". The check is case/name-exact, so mobileOnly is always false and the "skip defer on desktop" short-circuit is dead code — all instances go through IntersectionObserver on desktop too.

https://github.com/Rivka-Development/Dovetail-2026/blob/eb2d29aec18223e833680cb5d291c53e6e56e28c/assets/deferred-hydration.js#L14-L22

  1. search-modal.liquid no longer closes <dialog> (opened L11) or <predictive-search-component> (opened L25). Only </dialog-component> remains. Produces malformed DOM — the trailing <script>/<style> gets parsed inside the dialog scope, likely breaking predictive-search mount and focus trap.

https://github.com/Rivka-Development/Dovetail-2026/blob/eb2d29aec18223e833680cb5d291c53e6e56e28c/snippets/search-modal.liquid#L121-L125

  1. button.liquid schema declares padding-block-start, padding-block-end, padding-inline-start, padding-inline-end twice — once as type: "number" (L65-L83) and again as type: "range" (L147-L183). Shopify schemas reject duplicate setting ids; one definition will be silently dropped or the editor will error on the block.

First occurrence (number): https://github.com/Rivka-Development/Dovetail-2026/blob/eb2d29aec18223e833680cb5d291c53e6e56e28c/blocks/button.liquid#L63-L83

Duplicate (range): https://github.com/Rivka-Development/Dovetail-2026/blob/eb2d29aec18223e833680cb5d291c53e6e56e28c/blocks/button.liquid#L145-L184

  1. accordion.liquid, review.liquid, and product-recommendations.liquid now render their content inside <template> under <deferred-hydration>. Template content is inert — not rendered, not in SSR output, not indexed by crawlers that don't execute JS, and absent if JS fails. For FAQ/accordion copy and rating stars these are SEO/trust signals, not pure perf concerns. Combined with issue Horizon update to main #1, every desktop visitor also waits on IntersectionObserver for this content.

https://github.com/Rivka-Development/Dovetail-2026/blob/eb2d29aec18223e833680cb5d291c53e6e56e28c/blocks/accordion.liquid#L14-L21

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants