Fix flaky app-event-watcher test by replacing fragile setTimeout waits#7251
Merged
gonzaloriestra merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
The generateExtensionTypes and build error tests used a fixed 10ms setTimeout to wait for the async event processing chain to complete. This chain involves multiple async operations (handleWatcherEvents, updateContexts, rescanImports, buildExtensions, generateExtensionTypes, emit) and 10ms is not always enough. Replace all fragile setTimeout(10) waits with a polling mechanism that waits for the watcher's 'all' event to be emitted, matching the approach already used by the test.each block in the same file. This ensures tests only proceed once the full async processing chain has completed.
alfonso-noriega
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The generateExtensionTypes and build error tests used a fixed 10ms setTimeout to wait for the async event processing chain to complete. This chain involves multiple async operations (handleWatcherEvents, updateContexts, rescanImports, buildExtensions, generateExtensionTypes, emit) and 10ms is not always enough.
WHAT is this pull request doing?
Replace all fragile setTimeout(10) waits with a polling mechanism that waits for the watcher's 'all' event to be emitted, matching the approach already used by the test.each block in the same file. This ensures tests only proceed once the full async processing chain has completed.
How to test your changes?
CI
Checklist
pnpm changeset add