Skip to content

(feat/springVault): add configuration for spring vault - #48

Merged
ShantanuKumarSinha merged 7 commits into
mainfrom
feat/springVault
Mar 11, 2026
Merged

(feat/springVault): add configuration for spring vault#48
ShantanuKumarSinha merged 7 commits into
mainfrom
feat/springVault

Conversation

@ShantanuKumarSinha

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented Feb 28, 2026

Copy link
Copy Markdown

Qodana Community for JVM

1 new problem were found

Inspection name Severity Problems
Constant values ◽️ Notice 1
View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2025.2.3
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Spring Cloud Vault support to the service so runtime configuration (notably datasource credentials) can be externalized, while disabling Vault usage during tests.

Changes:

  • Added spring-cloud-starter-vault-config dependency.
  • Introduced Vault connection/config-import settings in application.properties and disabled Vault in test properties.
  • Added Vault setup notes to README.md (but currently includes sensitive output) and added a runtime log file to the repo.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/test/resources/application-test.properties Disables Vault for tests to prevent Vault from affecting test execution.
src/main/resources/application.properties Configures Vault connectivity and imports config from Vault at startup.
pom.xml Adds Spring Cloud Vault starter dependency.
logs/user-service.log Adds an application runtime log file to the repository (should not be committed).
README.md Documents local Vault usage, but currently contains real credential/token examples and command output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/resources/application.properties Outdated
Comment thread src/main/resources/application.properties Outdated
Comment thread README.md
Comment thread README.md Outdated
ShantanuKumarSinha and others added 2 commits February 28, 2026 16:05
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread src/main/resources/application.properties
Comment thread src/main/resources/application.properties
Comment thread pom.xml
Comment on lines 94 to +97
</dependency>
<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-starter-vault-config</artifactId>

Copilot AI Mar 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding spring-cloud-starter-vault-config makes Spring Cloud BOM alignment critical. This project uses Spring Boot 3.1.4 but imports spring-cloud-dependencies 2022.0.4, and the dependency tree in this PR shows mixed Spring Cloud versions (e.g., Eureka starter 4.1.0 with other Cloud artifacts at 4.0.x). Please align Spring Cloud dependencies with the Spring Boot version (e.g., upgrade the Spring Cloud BOM to a compatible release train for Boot 3.1 and avoid mixing explicit Spring Cloud versions).

Copilot uses AI. Check for mistakes.
Comment thread README.md
ShantanuKumarSinha and others added 2 commits March 11, 2026 22:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ShantanuKumarSinha
ShantanuKumarSinha merged commit d54644d into main Mar 11, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants