(feat/springVault): add configuration for spring vault - #48
Conversation
Qodana Community for JVM1 new problem were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.2.3
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
There was a problem hiding this comment.
Pull request overview
Adds Spring Cloud Vault support to the service so runtime configuration (notably datasource credentials) can be externalized, while disabling Vault usage during tests.
Changes:
- Added
spring-cloud-starter-vault-configdependency. - Introduced Vault connection/config-import settings in
application.propertiesand disabled Vault in test properties. - Added Vault setup notes to
README.md(but currently includes sensitive output) and added a runtime log file to the repo.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/test/resources/application-test.properties |
Disables Vault for tests to prevent Vault from affecting test execution. |
src/main/resources/application.properties |
Configures Vault connectivity and imports config from Vault at startup. |
pom.xml |
Adds Spring Cloud Vault starter dependency. |
logs/user-service.log |
Adds an application runtime log file to the repository (should not be committed). |
README.md |
Documents local Vault usage, but currently contains real credential/token examples and command output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| </dependency> | ||
| <dependency> | ||
| <groupId>org.springframework.cloud</groupId> | ||
| <artifactId>spring-cloud-starter-vault-config</artifactId> |
There was a problem hiding this comment.
Adding spring-cloud-starter-vault-config makes Spring Cloud BOM alignment critical. This project uses Spring Boot 3.1.4 but imports spring-cloud-dependencies 2022.0.4, and the dependency tree in this PR shows mixed Spring Cloud versions (e.g., Eureka starter 4.1.0 with other Cloud artifacts at 4.0.x). Please align Spring Cloud dependencies with the Spring Boot version (e.g., upgrade the Spring Cloud BOM to a compatible release train for Boot 3.1 and avoid mixing explicit Spring Cloud versions).
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.