(ref/test): refactor test cases - #38
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test cases by removing unused imports, commenting out mail configuration, enabling previously disabled tests, and adding a new logging interceptor.
- Cleaned up test imports and configurations to remove unnecessary dependencies
- Enabled a previously disabled integration test for product creation
- Added a new LoggerInterceptor for request/response logging with proper Spring MVC configuration
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| TestConfig.java | Commented out mail sender bean configuration for test environment |
| ProductServiceTest.java | Removed unused imports including ObjectMapper, UserServiceImpl, and WebClient |
| McProductServiceApplicationTests.java | Enabled disabled test, added MockMvc configuration, and activated test profile |
| EmailServiceTest.java | Reordered imports and updated commented assertion |
| UserServiceImpl.java | Refactored static fields to instance variables with PostConstruct initialization |
| LoggerInterceptor.java | Added new interceptor class for logging HTTP requests and responses |
| McProductServiceApplication.java | Added interceptor configuration and reorganized field declarations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…terceptor.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.