Fix the merge damage in create_extn, plus two bugs the real schema surfaced#3
Open
sparkyfen wants to merge 2 commits into
Open
Fix the merge damage in create_extn, plus two bugs the real schema surfaced#3sparkyfen wants to merge 2 commits into
sparkyfen wants to merge 2 commits into
Conversation
The publish column is boolean (per the schema supersat posted in Shadytel#2), and asyncpg rejects a str parameter for a boolean column, so inserting the string 't'/'f' fails with a DataError. Pass a real bool instead.
The homepage row form posts the checkbox as 'published', but the non-admin path read 'publish' with a default of '1', so a regular user could never unpublish a line. Use the same key and default as the admin path.
sparkyfen
force-pushed
the
fix-create-extn-indent
branch
from
July 10, 2026 06:16
2143348 to
979ddfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: supersat fixed the parse-breaking indentation directly on main in 626040e, so that commit dropped out of this PR in the rebase. What's left is the two bugs found by testing against the schema posted in #2:
create_extnbound't'/'f'strings forpublish, but the column isbooleanand asyncpg rejects a str parameter for a bool column — every activation would have been a 500. It now binds a real bool. (TheWHERE publish = 't'literals elsewhere are fine, Postgres casts those.)published, but the non-admin path ofpublish_extnreadpublishwith a default of'1'— so a regular user could never unpublish a line. It now reads the same key and default as the admin path.Tested with the dev environment from #2 (rebased on this) against the definitive schema: activation with good/bad/duplicate input, SIP and POTS, and unpublish/republish showing up in the directory. #2 is stacked on this branch, so merging this first keeps that one clean.