Migrate All Components to TS#23
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
היי @Yedidyar , אני בעומס בעבודה עד שבוע הבא, מבטיח להגיע לזה בהקדם וגם לעשות כבר merge למאסטר 😁 |
|
מעולה 💫 |
thebne
left a comment
thebne
left a comment
There was a problem hiding this comment.
went through half of it, added some comments for now.
were you able to test it with actual data? there were some minor things I noticed that could potentially break the intended logic.
|
I tested it from time to time i will check again when i will resolve the comments. |
|
the ci do not pass but i do not have access to the logs |
|
Error: Node.js Version "14.x" is discontinued and must be upgraded. Please set Node.js Version to 18.x in your Project Settings to use Node.js 18. @Yedidyar |
|
It seems that the settings in the cicd project need to be changed |
He i think i cant fixed at my end P.S can you review the rest of the code i would like to finish this migration and start working on more issues |
3 participants
the only file that not been migrated is bubble.js