[WIP] Added BCQ#378
Draft
sampreet-arthi wants to merge 20 commits into
Draft
Conversation
Member
Author
|
Buffers have been tested but not after the addition of BCQ so tests are failing rn |
|
This pull request introduces 3 alerts when merging 6c271ef into b8a45ab - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
- Coverage 91.28% 88.51% -2.77%
==========================================
Files 90 93 +3
Lines 3809 3944 +135
==========================================
+ Hits 3477 3491 +14
- Misses 332 453 +121
|
|
This pull request introduces 4 alerts when merging b28c1e6 into a2c8c7e - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 3db4733 into 25eb018 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 43a483e into 25eb018 - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stuff implemented:
OffPolicyAgentAC. Architecture was very similar to TD3. Major differences were that the actor took in both state and action as input and the VAE obviously.OfflineTrainerinherits fromOffPolicyTrainer. Only difference is that it loads the buffer.BaseBufferand remove redundant functions and converted all code to torch. No numpy is used in any of the buffer files now.Stuff to do: