Handle duplicate verifier names in results (isolated from #17) - #24
Open
BinRoot wants to merge 1 commit into
Open
Handle duplicate verifier names in results (isolated from #17)#24BinRoot wants to merge 1 commit into
BinRoot wants to merge 1 commit into
Conversation
Running the benchmark showed that duplicate verifier names in the dataset caused earlier results to be silently overwritten in the verification_results dictionary, which unfortunately hid failures such as the broken SQL query in Issue ServiceNow#8. To address this, a dynamic key deduplication mechanism was added to safely append numerical suffixes (e.g. _1, _2) to colliding names. This ensures that each individual verifier result is well recorded and exposed . The original dictionary value structure is strictly preserved to ensure perfect backward compatibility with downstream statistical calculations .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #23.
Repeated names overwrote earlier results, so now colliding keys get a unique numeric suffix.
Cherry-picking @Ctrl408's commit from #17 onto main, to decouple it from an unrelated docker-compose.yml.