Esto debería mejorar bastante la velocidad del modelo#2
Open
VichoReyes wants to merge 6 commits into
Open
Conversation
daa4845 to
5207334
Compare
Collaborator
Author
Owner
|
Me da el siguiente error: Estoy usando pandas-1.0.1 |
Collaborator
Author
|
@Sergio-P No es tema de pandas, es de pytorch. Hace poco añadieron el tipo bool y si usas la versión 1.3 te tira warnings si usas uint8 para expresar cosas booleanas (que es como se hacía antes). La parte tonta es que si usas 1.0.1 el tipo bool está implementado, pero not no está implementado. Decidí usarlo igual porque mejor ser compatible con el futuro que con el pasado, no? |
The negation operator isn't implemented for torch.bool tensors. This commit does the negations using simple python booleans as a workaround.
Collaborator
Author
|
Ahí va |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Todavía faltan algunas cosas eso sí. Por ejemplo, como cambié la función select_rules por otra, el rmap no se va a poblar automáticamente con el entrenamiento. Ahí tienes que decidir si eliminarlo o poblarlo intencionalmente. Por el motivo anterior, no funciona el ejemplo del breast cancer, ya que el main intenta usar directamente el rmap. La función select_rules tuya no la he eliminado porque se usa en varias partes además de forward. Deberíamos ver qué hacer al respecto.
Además, ya no tiene mucho sentido el flag "precompute_rules" porque la matriz de r x n booleanos se hará igual.