Skip to content

Fix missing RateTolerance assignment in test execution#40

Draft
Claude wants to merge 2 commits into
masterfrom
claude/fix-tolerances-and-timeouts
Draft

Fix missing RateTolerance assignment in test execution#40
Claude wants to merge 2 commits into
masterfrom
claude/fix-tolerances-and-timeouts

Conversation

@Claude
Copy link
Copy Markdown

@Claude Claude AI commented Mar 24, 2026

Changes proposed in this pull request:

  • Add missing RateTolerance = e.RateTolerance assignment in Test.cs:436

The ProcessEvents() method was not transferring the user-configured RateTolerance value from EventSetting to TestVariable, causing it to default to 0 during test execution while the other four tolerance/timeout values (ErrorTolerance, DwellTime, Timeout, Interval) were correctly assigned.

TestVariable testVariable = new()
{
    Setpoint = e.Value,
    ErrorTolerance = e.ErrorTolerance,
    RateTolerance = e.RateTolerance,  // Added
    Interval = new TimeSpan(0, 0, Convert.ToInt32(e.Interval)),
    Timeout = new TimeSpan(0, 0, Convert.ToInt32(e.Timeout)),
    DwellTime = new TimeSpan(0, 0, Convert.ToInt32(e.DwellTime))
};

@SensitTechnologies/test-suite-developers

Original prompt

This section details on the original issue you should resolve

<issue_title>Tolerances and Timeouts</issue_title>
<issue_description>Describe the bug
Error Tolerance, Rate Tolerance, Dwell Time, Timeout, Interval are not known to work

To Reproduce
Steps to reproduce the behavior:

  1. Run Sensit.App.Automate.
  2. Open any default test template.
  3. Navigate to the "Events" tab.
  4. Expand the right side of the app to view the tolerance and timeout values for each event.
  5. Change one or more values.
  6. Run the test.
  7. Observe whether the tolerance and timeout values work correctly.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: Windows 11 x64
  • Equipment: Mass Flow Controller (x2), with serial cables and power supplies, air supply</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

The RateTolerance property was not being assigned from EventSetting to TestVariable,
causing the user-configured RateTolerance value from the Events tab to be ignored
during test execution. This resulted in the default value of 0 being used instead.

This fix ensures that all tolerance and timeout values (ErrorTolerance, RateTolerance,
DwellTime, Timeout, and Interval) are properly transferred from the EventSetting
configuration to the TestVariable object used during test execution.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Co-authored-by: adamj537 <11276599+adamj537@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SensitTechnologies/TestSuite/sessions/bbfb792f-9581-4f23-864a-fcfc7b9e0954
@Claude Claude AI changed the title [WIP] Fix error tolerance and timeout handling in events Fix missing RateTolerance assignment in test execution Mar 24, 2026
@Claude Claude AI requested a review from adamj537 March 24, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tolerances and Timeouts

2 participants