Skip to content

Add --player-volume option#267

Open
chatziko wants to merge 2 commits into
Sendspin:mainfrom
chatziko:player-volume
Open

Add --player-volume option#267
chatziko wants to merge 2 commits into
Sendspin:mainfrom
chatziko:player-volume

Conversation

@chatziko

Copy link
Copy Markdown
Contributor

Adds a --player-volume CLI option (available in both the interactive player and daemon modes) that sets the player's initial output volume on startup, overriding the saved player_volume setting. Mirrors how existing options work (eg --static-delay-ms).

It's useful for always starting with a fixed volume, but also combined with volume hooks (which don't set an initial volume).

Copilot AI review requested due to automatic review settings June 24, 2026 10:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new --player-volume CLI option to control the player’s initial output volume at startup (in both TUI and daemon modes), intended to take precedence over the persisted player_volume setting.

Changes:

  • Adds --player-volume argument parsing for the player and daemon subcommands.
  • Plumbs player_volume through AppArgs / DaemonArgs and uses it when constructing AudioStreamHandler.
  • Updates README settings table to reference the new CLI option.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
sendspin/tui/app.py Adds player_volume to AppArgs and uses it to initialize AudioStreamHandler.
sendspin/daemon/daemon.py Adds player_volume to DaemonArgs and uses it to initialize AudioStreamHandler.
sendspin/cli.py Adds --player-volume CLI flag and passes it into TUI/daemon argument structs.
README.md Mentions --player-volume alongside the player_volume setting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sendspin/tui/app.py
Comment thread sendspin/daemon/daemon.py
Comment thread sendspin/cli.py
Comment thread sendspin/tui/app.py
Comment thread sendspin/daemon/daemon.py
Comment thread sendspin/cli.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants