Add --player-volume option#267
Open
chatziko wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new --player-volume CLI option to control the player’s initial output volume at startup (in both TUI and daemon modes), intended to take precedence over the persisted player_volume setting.
Changes:
- Adds
--player-volumeargument parsing for the player and daemon subcommands. - Plumbs
player_volumethroughAppArgs/DaemonArgsand uses it when constructingAudioStreamHandler. - Updates README settings table to reference the new CLI option.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
sendspin/tui/app.py |
Adds player_volume to AppArgs and uses it to initialize AudioStreamHandler. |
sendspin/daemon/daemon.py |
Adds player_volume to DaemonArgs and uses it to initialize AudioStreamHandler. |
sendspin/cli.py |
Adds --player-volume CLI flag and passes it into TUI/daemon argument structs. |
README.md |
Mentions --player-volume alongside the player_volume setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--player-volumeCLI option (available in both the interactive player anddaemonmodes) that sets the player's initial output volume on startup, overriding the savedplayer_volumesetting. Mirrors how existing options work (eg--static-delay-ms).It's useful for always starting with a fixed volume, but also combined with volume hooks (which don't set an initial volume).