Visualizer follow-up fixes#264
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up fixes to the TUI visualizer to better handle servers that don’t negotiate visualizer@v1, while keeping timeline-strip animation working correctly with peaks-only activity.
Changes:
- Hide/disable the visualizer panel when
server/hellodoes not reportvisualizer@v1as an active role. - Keep periodic visualizer refreshes running when peak activity is present (so the peak strip continues animating even without beats).
- Update stale/incorrect visualizer-related comments/docstrings for accuracy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sendspin/tui/visualizer.py |
Corrects a stale comment to match the actual playhead glyphs used. |
sendspin/tui/ui.py |
Includes peak activity in the refresh decision and updates the visualizer layout docstring to match current behavior. |
sendspin/tui/app.py |
Adds server/hello handling to disable the visualizer UI when the server doesn’t activate the visualizer role. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #259.
Hides the visualizer panel when the server doesn't activate
visualizer@v1, instead of showing an empty panel that never receives data. Also keeps the peak strip animating when only peaks are active, and corrects two stale visualizer comments.