Skip to content

Update DSv4 GB300 Dynamo SGLang MTP image#1637

Open
Fridge003 wants to merge 4 commits into
mainfrom
codex/sglang-nightly-20260527
Open

Update DSv4 GB300 Dynamo SGLang MTP image#1637
Fridge003 wants to merge 4 commits into
mainfrom
codex/sglang-nightly-20260527

Conversation

@Fridge003
Copy link
Copy Markdown
Collaborator

@Fridge003 Fridge003 commented Jun 2, 2026

Summary


Note

Low Risk
Config-only image tag and changelog update with no application or auth logic changes.

Overview
Bumps the container image for dsv4-fp4-gb300-dynamo-sglang-mtp from lmsysorg/sglang:nightly-dev-cu13-20260509-9ee83034 to lmsysorg/sglang:nightly-dev-20260527-14f81a67 in .github/configs/nvidia-master.yaml.

Adds a matching perf-changelog.yaml entry for that config key documenting the image change (PR #1637).

Reviewed by Cursor Bugbot for commit 6ce9969. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a2c5d68. Configure here.

# MTP variant of dsv4-fp4-gb300-dynamo-sglang.
dsv4-fp4-gb300-dynamo-sglang-mtp:
image: lmsysorg/sglang:nightly-dev-cu13-20260509-9ee83034
image: lmsysorg/sglang:nightly-dev-20260527-14f81a67
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTP image missing cu13 tag for GB300 hardware

High Severity

The image was changed from nightly-dev-cu13-20260509-9ee83034 (CUDA 13) to nightly-dev-20260527-14f81a67 (CUDA 12). SGLang publishes separate nightly-dev-* and nightly-dev-cu13-* variants for CUDA 12 and CUDA 13 respectively. The sibling config dsv4-fp4-gb300-dynamo-sglang on the same gb300-cw runner correctly uses nightly-dev-cu13-20260520-425dffbd. Running a CUDA 12 image on GB300 hardware requiring CUDA 13 will likely cause runtime failures.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a2c5d68. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

@Oseltamivir Oseltamivir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Oseltamivir
Copy link
Copy Markdown
Collaborator

/reuse-sweep-run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants