refactor(inference): data-driven config exclusion#415
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e28bb0d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches inference legend selection, presets, and DSv4 default chart behavior; behavior is intended to match prior MTP rules plus new ATOM/SGLang grouping, with broad test coverage but user-visible chart filtering changes.
Overview
Replaces the hard-coded MTP engine-family exclusion (
mtp-exclusion.ts+mtpEngineExclusionflag) with a data-drivenexclusionmodule: models declareExclusionSpec[](suffix, prefix stripping, group aliases), compiled viabuildExclusionfor legend toggles, presets, and auto-reset.DeepSeek V4 Pro now uses
MTP_ENGINE_EXCLUSIONon*_mtpkeys, with ATOM and SGLang in one comparability group (groupAliases: { atom: 'sglang' }) so they can appear together but stay mutually exclusive with vLLM MTP. Preset bare-GPU matching skips keys ending in any configured exclusion suffix viagetModelExclusion.InferenceContextwires the generic helpers (resolveExclusionToggle,clearAllExclusionGroups,effectiveLegendItems); existing MTP conflict toasts are unchanged. Tests move frommtp-exclusion.test.tstoexclusion.test.tswith coverage for the ATOM/SGLang group behavior.Reviewed by Cursor Bugbot for commit e28bb0d. Bugbot is set up for automated code reviews on this repo. Configure here.