Skip to content

refactor(inference): data-driven config exclusion#415

Merged
adibarra merged 1 commit into
masterfrom
fix/mtp-exclusive-comparison
Jun 2, 2026
Merged

refactor(inference): data-driven config exclusion#415
adibarra merged 1 commit into
masterfrom
fix/mtp-exclusive-comparison

Conversation

@adibarra
Copy link
Copy Markdown
Contributor

@adibarra adibarra commented Jun 2, 2026

Note

Medium Risk
Touches inference legend selection, presets, and DSv4 default chart behavior; behavior is intended to match prior MTP rules plus new ATOM/SGLang grouping, with broad test coverage but user-visible chart filtering changes.

Overview
Replaces the hard-coded MTP engine-family exclusion (mtp-exclusion.ts + mtpEngineExclusion flag) with a data-driven exclusion module: models declare ExclusionSpec[] (suffix, prefix stripping, group aliases), compiled via buildExclusion for legend toggles, presets, and auto-reset.

DeepSeek V4 Pro now uses MTP_ENGINE_EXCLUSION on *_mtp keys, with ATOM and SGLang in one comparability group (groupAliases: { atom: 'sglang' }) so they can appear together but stay mutually exclusive with vLLM MTP. Preset bare-GPU matching skips keys ending in any configured exclusion suffix via getModelExclusion.

InferenceContext wires the generic helpers (resolveExclusionToggle, clearAllExclusionGroups, effectiveLegendItems); existing MTP conflict toasts are unchanged. Tests move from mtp-exclusion.test.ts to exclusion.test.ts with coverage for the ATOM/SGLang group behavior.

Reviewed by Cursor Bugbot for commit e28bb0d. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
inferencemax-app Ready Ready Preview, Comment Jun 2, 2026 12:34am

Request Review

@adibarra adibarra marked this pull request as ready for review June 2, 2026 00:34
@adibarra adibarra merged commit b3437e8 into master Jun 2, 2026
24 checks passed
@adibarra adibarra deleted the fix/mtp-exclusive-comparison branch June 2, 2026 00:39
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e28bb0d. Configure here.

Comment thread packages/app/src/lib/data-mappings.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant