Replace the MySQL 9.7 CI leg with MariaDB 11.8#90
Merged
Conversation
The extension's test suite does not exercise the SQLStore paths where MySQL and MariaDB diverge, so the MySQL leg added coverage in name only (and SMW core does not yet pass on MySQL 9.7). Run the extension on MariaDB only; the matrix is now 10.11 / 11.4 / 11.8 / 12.3.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage 26.35% 26.35%
Complexity 48 48
=========================================
Files 3 3
Lines 129 129
=========================================
Hits 34 34
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the per-MW MariaDB LTS matrix: drop the
mysql:9.7CI leg and run the extension on MariaDB only (10.11/11.4/11.8/12.3).A leaf extension's test suite doesn't exercise the SQLStore paths where MySQL and MariaDB diverge, so the MySQL row added coverage in name only — and SMW core itself does not yet pass on MySQL 9.7. MySQL engine coverage belongs in SMW core's CI, not the extensions.