Support Semantic MediaWiki 7.0#89
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=========================================
Coverage 26.35% 26.35%
Complexity 48 48
=========================================
Files 3 3
Lines 129 129
=========================================
Hits 34 34
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Realign the major version with Semantic MediaWiki (3.x -> 7.0.0-alpha; versions 4.x-6.x are skipped) and raise the minimum requirements to MediaWiki 1.43, Semantic MediaWiki 7.0 and PHP 8.1. * Fix the compoundquery API module for SMW 7.0: SMW\MediaWiki\Api\Query now requires a QuerySourceFactory constructor argument, so register the module with the SMW.QuerySourceFactory service instead of a bare class name. * Adopt MediaWiki-namespaced imports (MediaWiki\Parser\Parser, MediaWiki\Api\ApiBase, MediaWiki\Api\ApiFormatXml) and SMW 7.0 class names (SMW\Query\Query, SMW\Query\QueryProcessor); drop inline FQN. * Modernise the toolchain: mediawiki-codesniffer, minus-x and parallel-lint with composer analyze/test/unit/integration/phpcs-fix scripts, plus a .phpcs.xml ruleset; bring src/ and tests into compliance and use SPDX license identifiers. * Rework CI for MediaWiki 1.43-1.45 and PHP 8.1-8.4 with a per-version MariaDB LTS spread (10.11/11.4/11.8/12.3); remove the obsolete Travis and Scrutinizer configuration. * Make Codecov project/patch status checks informational so coverage deltas do not gate CI.
alistair3149
force-pushed
the
support-smw-7.0
branch
from
f86b519 to
182969c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Semantic MediaWiki 7.0 and realigns the major version with SMW (
3.x→7.0.0-alpha; versions4.x–6.xare skipped to match SMW's major). Minimum requirements are raised to MediaWiki 1.43, Semantic MediaWiki 7.0, and PHP 8.1.SMW 7.0 compatibility
SMW\MediaWiki\Api\Query::__construct()now requires a thirdQuerySourceFactoryargument. ThecompoundqueryAPI module (a subclass of that base) is now registered with theSMW.QuerySourceFactoryservice via an ObjectFactory spec, mirroring how SMW registers its ownask/askargsmodules.SMWQuery→SMW\Query\Query,SMWQueryProcessor→SMW\Query\QueryProcessor.Code modernisation
MediaWiki\Parser\Parser,MediaWiki\Api\ApiBase,MediaWiki\Api\ApiFormatXml); replaced inline fully-qualified names withuseimports.GPL-2.0-or-later) and PHP 8.1 native types where code was touched.Tooling & CI
composer.json: PHP>= 8.1;mediawiki-codesniffer,minus-x,parallel-lint;analyze/test/unit/integration/phpcs-fixscripts;branch-alias7.0.0-dev. Added a.phpcs.xmlruleset.dev-master, each row on a distinct currently-supported MariaDB LTS (10.11 / 11.4 / 11.8 / 12.3);actions/checkout@v6,codecov/codecov-action@v6. Codecov project/patch checks are informational so coverage deltas do not gate CI.Testing
composer analyze(parallel-lint + PHPCS + minus-x) is clean andcomposer phpunitpasses (62 tests, 120 assertions) against SMWdev-masteron MediaWiki 1.43 / PHP 8.1.