Linux linking#10
Open
lucasw wants to merge 3 commits into
Open
Conversation
Author
|
I thought maybe a PR would override the github action restriction on only running on main, but given it doesn't there's another very similar branch modified to do actions on all branches that shows success: https://github.com/lucasw/jolt-rust/actions/runs/17313804077 |
|
the link order fix (joltc before Jolt) and lib64 search path are now in main. the hello-world build.rs additions weren't needed since joltc-sys handles linking for downstream crates. closing in favor of the direct fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got linux building with a build.rs per hello world, and also cargo test needs linking to happen right where I've moved it to (not sure why).
Fixes #9 and #5