fix(frontend): name repository row actions - #286
Conversation
Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
parthrohit22
left a comment
There was a problem hiding this comment.
Hi @adity982 , thanks for the clean, well-scoped fix and for the honest test notes (including the disclosed #179 timeout). The code change is correct: handlers are unchanged, and you handled the private-roadmap constraint properly by scoping alignment to #235 .
I am requesting changes as,
Blocking: the public WCAG baseline doc still lists #235 as an open violation.
The PR body says #235 was "removed from the accepted axe baseline findings" — that's true for accessibility.spec.ts, but docs/accessibility/WCAG_2_2_AA_BASELINE.md still records it as a live confirmed violation at line 106, and its own rule at line 110 states no confirmed violation may be left only in the report. As written, the public doc asserts a violation the code no longer has, and the "No visible documentation change is required" checklist item is therefore inaccurate. Please strike that row and add a resolved note, e.g.:
/repositories, success list | Every open/delete icon action lacks a repository-specific accessible name (button-name) … | #235
Resolved by #286 — open/delete actions now carry repository-specific accessible names (Open <repo>/Delete <repo>); icons marked decorative.
Then re-run npm run lint:frontend and npm --prefix apps/frontend test -- --run, and push to the same branch. The component test, E2E per-fixture assertions, and aria-hidden handling are all good as-is - this doc edit is the only blocker; approval follows once it lands.
keep up the good work.
Tested: read the full handler block in RepositoriesPage.tsx (onClick unchanged), the new component test, and the E2E delta; confirmed CI is running (CodeQL passed, CI in progress) and the fork-PR workflow-approval gate is the expected first-run behaviour.
Mapped against: the public WCAG 2.2 AA baseline doc (line 106 still lists #235; its own line 110 forbids a confirmed violation remaining only in the report) and the PR's stated acceptance criteria.
Summary
Give every repository-row open and delete action a repository-specific accessible name, hide the decorative icons from assistive technology, and pin the behavior in component and WCAG baseline coverage.
Linked issue
Closes #235
Roadmap alignment
What changed
Open <repository>andDelete <repository>labels to the existing row actions.Acceptance criteria completed
Testing performed
Screenshots
Not applicable. This changes accessibility semantics without changing the visible UI.
Security and data considerations
None. No auth, persistence, request, or data-handling behavior changed.
Dependencies and blocked work
None.
Scope changes or remaining work
The public checkout does not include the private roadmap file, so the roadmap workstream wording above follows the alignment recorded in issue #235. No implementation work was deferred.
Contributor checklist
devupstream/devReviewer requested by the contribution guide: @parthrohit22