Fix preprocessor statements close to empty lines - #15
Merged
Conversation
Preprocessor statement after non-preprocessor statements with empty lines in between would result in the preprocessor statement being appended to the end of the non-proprocessor statement: int demo(); #include<vector> Would be incorrectly minified to int demo();#include<vector> This change updates the pre-process fix logic to apply new lines more generally, and then adds a post processing step to remove excessively long series of new lines. Type: Bug Fix
C/C++ use ?, : and :: as 'operators' in a few different contexts. Added these operators to the supported operator list, and added a unit test case that spans a variety of valid places these operators could appear. Type: New Feature
Owner
|
Thanks for the PR ! However I just wanted to stress that this is first and foremost a C minifier and not really a C++ minifier. Great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this situation wouldn't typically come up for well designed C/C++ source... I am up to no good:
MarcosCosmos/cg-cpp-bundler#2