VC3D: cast seeding rays on active plane#1053
Open
LubuSeb wants to merge 1 commit into
Open
Conversation
|
@LubuSeb is attempting to deploy a commit to the scroll Team on Vercel. A member of the Team first needs to authorize it. |
82db5f8 to
c9615e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #372 by making point-mode seeding rays follow the segmentation plane that provided the focus point:
Draw-mode path analysis is left unchanged.
Reproduction
The current point-mode seeding path always offsets X/Y and keeps Z constant when previewing or casting rays. That means a focus point set from the XZ or YZ segmentation panes still casts on the XY plane, even though issue #372 asks those panes to cast on XZ and YZ respectively.
Scope
Minimality/scope rationale: this patch is focused and only changes
SeedingWidget.cpp; it does not include unrelated refactors. It adds small plane-mapping helpers and uses them in the point-mode preview/cast paths and the point-mode parameter preview. It does not change neural trace behavior, draw-mode path peak finding, segmentation growth, or any saved surface geometry.Issue / Artifact Binding
Issue binding: #372 (
challenge-prize:ScrollPrize/villa#372).Artifact link: this pull request is the patch artifact for that issue. The Vesuvius Open Prizes page says VC3D improvements may be considered for Progress Prizes, but this PR is submitted as a normal issue fix and does not request or guarantee a payout, bounty, or reward.
Validation
Ran in Docker with
ghcr.io/scrollprize/villa/volume-cartographer:builder-ubuntu-26.04:Result:
97/97tests passed.Also ran a Qt offscreen GUI startup smoke test because the builder image does not include
xvfb-runorXvfb:Exit code
124is expected fromtimeout; VC3D started and initialized before the timeout stopped it.Known Limits
I did not run an interactive desktop click-through. This PR is linked to issue #372 and may be relevant to the Vesuvius Progress Prize wishlist for VC3D improvements, but it does not claim or guarantee any prize award.