Skip to content

chore: rename SCRAWN_KEY to MASTER_API_KEY, add MASTER_API_KEY_HASH, … - #96

Merged
SteakFisher merged 1 commit into
devfrom
feat/cli_autogen
Jul 1, 2026
Merged

chore: rename SCRAWN_KEY to MASTER_API_KEY, add MASTER_API_KEY_HASH, …#96
SteakFisher merged 1 commit into
devfrom
feat/cli_autogen

Conversation

@SteakFisher

Copy link
Copy Markdown
Member

…update proto submodule

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates production deployment wiring for the renamed master API key variables. The main changes are:

  • Adds MASTER_API_KEY_HASH to the server service environment.
  • Renames the dashboard secret from SCRAWN_KEY to MASTER_API_KEY in docker-compose.yml.
  • Advances the proto submodule pointer.

Confidence Score: 5/5

Safe to merge with minimal risk.

The visible changes are limited to Docker Compose environment wiring and a submodule pointer update. The compose variable names match the server-side MASTER_API_KEY_HASH lookup present in the repository. No blocking bugs or security concerns were identified.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • Verified environment rename impact by comparing before and after compose-env outputs, confirming the expected keys and redactions.
  • Checked submodule state, observing a clean base checkout at commit d9ceee648e170df091eff3fbd04dbc29ebd056bd, then a head submodule update failure due to not our ref, blocking consumption of the updated proto contract.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
docker-compose.yml Production compose now passes MASTER_API_KEY_HASH to the server and renames the dashboard secret input to MASTER_API_KEY; no issues found.
proto Updates the proto submodule pointer from d9ceee6 to e4b7237.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
  participant Operator as Deployment operator
  participant Compose as docker-compose.yml
  participant Dashboard as dashboard service
  participant Server as server service

  Operator->>Compose: Provides MASTER_API_KEY and MASTER_API_KEY_HASH
  Compose->>Server: Injects MASTER_API_KEY_HASH
  Compose->>Dashboard: Injects MASTER_API_KEY
  Dashboard->>Server: Sends Bearer MASTER_API_KEY
  Server->>Server: HMAC key and compare with MASTER_API_KEY_HASH
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
  participant Operator as Deployment operator
  participant Compose as docker-compose.yml
  participant Dashboard as dashboard service
  participant Server as server service

  Operator->>Compose: Provides MASTER_API_KEY and MASTER_API_KEY_HASH
  Compose->>Server: Injects MASTER_API_KEY_HASH
  Compose->>Dashboard: Injects MASTER_API_KEY
  Dashboard->>Server: Sends Bearer MASTER_API_KEY
  Server->>Server: HMAC key and compare with MASTER_API_KEY_HASH
Loading

Comments Outside Diff (1)

  1. General comment

    P1 Head points proto submodule at an unreachable commit

    • Bug
      • A fresh checkout of head 518433277a2e601bf3182ec280df05da3553b747 cannot initialize the proto submodule at the claimed new commit e4b7237de066160224b9a71d72d5c3824897d8a3. git submodule update --init --recursive proto fails because the remote reports that commit is not available. This prevents consumers from checking out and using the updated protobuf/API contract from the documented submodule source.
    • Cause
      • The superproject records a gitlink to e4b7237de066160224b9a71d72d5c3824897d8a3, but that object is not present/fetchable from the configured submodule remote https://github.com/ScrawnDotDev/.proto.
    • Fix
      • Push the e4b7237de066160224b9a71d72d5c3824897d8a3 commit to the configured .proto remote, or update the superproject gitlink to a commit that is present and fetchable from that remote, then re-run submodule initialization and the proto generation workflow.

    T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "chore: rename SCRAWN_KEY to MASTER_API_K..." | Re-trigger Greptile

@SteakFisher
SteakFisher merged commit d0986f5 into dev Jul 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant