Skip to content

Add Claude Opus 5 capabilities #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yaacovcorcos wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Claude Opus 5 capabilities #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
211 changes: 211 additions & 0 deletions apps/server/src/provider/Layers/ClaudeAdapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ function makeHarness(config?: {
readonly nativeEventLogger?: ClaudeAdapterLiveOptions["nativeEventLogger"];
readonly cwd?: string;
readonly baseDir?: string;
readonly claudeVersion?: string | null;
}) {
const query = new FakeClaudeQuery();
let createInput:
Expand All @@ -201,6 +202,11 @@ function makeHarness(config?: {
nativeEventLogPath: config.nativeEventLogPath,
}
: {}),
...(config && Object.hasOwn(config, "claudeVersion")
? {
resolveClaudeVersion: () => Effect.succeed(config.claudeVersion ?? null),
}
: {}),
};

return {
Expand Down Expand Up @@ -310,6 +316,11 @@ function effortLevelFromOptions(
return settings && typeof settings === "object" ? settings.effortLevel : undefined;
}

function fastModeFromOptions(options: ClaudeQueryOptions | undefined): boolean | undefined {
const settings = options?.settings;
return settings && typeof settings === "object" ? settings.fastMode : undefined;
}

const THREAD_ID = ThreadId.makeUnsafe("thread-claude-1");
const RESUME_THREAD_ID = ThreadId.makeUnsafe("thread-claude-resume");

Expand Down Expand Up @@ -447,6 +458,102 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("scopes pre-session agent discovery and caching to the Claude executable", () => {
const queries: FakeClaudeQuery[] = [];
const discoveryContexts: Array<{
executable: string | undefined;
cwd: string | undefined;
}> = [];
const layer = makeClaudeAdapterLive({
createQuery: (input) => {
const query = new FakeClaudeQuery();
const executable = input.options.pathToClaudeCodeExecutable;
const cwd = input.options.cwd;
discoveryContexts.push({ executable, cwd });
Object.assign(query, {
supportedAgents: async () => [
{
name:
executable === "/managed/claude-a" && cwd === "/tmp/project"
? "agent-a"
: executable === "/managed/claude-b"
? "agent-b"
: "agent-other-cwd",
description: `from ${executable} in ${cwd}`,
model: "inherit",
},
],
});
queries.push(query);
return query;
},
}).pipe(
Layer.provideMerge(ServerConfig.layerTest("/tmp/claude-agent-discovery", "/tmp")),
Layer.provideMerge(NodeServices.layer),
);

return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;
if (!adapter.listAgents) {
return assert.fail("Claude adapter should support agent discovery.");
}

const first = yield* adapter.listAgents({
provider: "claudeAgent",
cwd: "/tmp/project",
binaryPath: "/managed/claude-a",
});
const second = yield* adapter.listAgents({
provider: "claudeAgent",
cwd: "/tmp/project",
binaryPath: "/managed/claude-b",
});
const otherCwd = yield* adapter.listAgents({
provider: "claudeAgent",
cwd: "/tmp/other-project",
binaryPath: "/managed/claude-a",
});
const firstCached = yield* adapter.listAgents({
provider: "claudeAgent",
cwd: "/tmp/project",
binaryPath: "/managed/claude-a",
});

assert.deepEqual(discoveryContexts, [
{ executable: "/managed/claude-a", cwd: "/tmp/project" },
{ executable: "/managed/claude-b", cwd: "/tmp/project" },
{ executable: "/managed/claude-a", cwd: "/tmp/other-project" },
]);
assert.deepEqual(
first.agents.map((agent) => agent.name),
["agent-a"],
);
assert.deepEqual(
second.agents.map((agent) => agent.name),
["agent-b"],
);
assert.deepEqual(
otherCwd.agents.map((agent) => agent.name),
["agent-other-cwd"],
);
assert.equal(first.cached, false);
assert.equal(second.cached, false);
assert.equal(otherCwd.cached, false);
assert.equal(firstCached.cached, true);
assert.deepEqual(
firstCached.agents.map((agent) => agent.name),
["agent-a"],
);
assert.deepEqual(
queries.map((query) => query.closeCalls),
[1, 1, 1],
);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(layer),
);
});

it.effect("disables Claude self-updates only for a Scient-managed executable", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down Expand Up @@ -721,6 +828,83 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("starts an Opus alias with its native context suffix and supported options", () => {
const harness = makeHarness({ claudeVersion: "2.1.219" });
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;
yield* adapter.startSession({
threadId: THREAD_ID,
provider: "claudeAgent",
modelSelection: {
provider: "claudeAgent",
model: "opus[1m]",
options: {
effort: "xhigh",
autoCompactWindow: "1m",
fastMode: true,
},
},
runtimeMode: "full-access",
});

const createInput = harness.getLastCreateQueryInput();
assert.equal(createInput?.options.model, "claude-opus-5[1m]");
assert.equal(autoCompactWindowFromOptions(createInput?.options), 1_000_000);
assert.equal(effortLevelFromOptions(createInput?.options), "xhigh");
assert.equal(fastModeFromOptions(createInput?.options), true);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("falls back persisted Opus aliases when the Claude runtime is too old", () => {
const harness = makeHarness({ claudeVersion: "2.1.218" });
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;
const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: "claudeAgent",
modelSelection: {
provider: "claudeAgent",
model: "opus[1m]",
options: { effort: "ultracode", fastMode: true },
},
runtimeMode: "full-access",
});

const createInput = harness.getLastCreateQueryInput();
assert.equal(createInput?.options.model, "claude-opus-4-8[1m]");
assert.equal(session.model, "claude-opus-4-8[1m]");
assert.equal(effortLevelFromOptions(createInput?.options), "xhigh");
assert.equal(fastModeFromOptions(createInput?.options), true);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("fails closed to Opus 4.8 when the Claude runtime version is unknown", () => {
const harness = makeHarness({ claudeVersion: null });
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;
yield* adapter.startSession({
threadId: THREAD_ID,
provider: "claudeAgent",
modelSelection: {
provider: "claudeAgent",
model: "claude-opus-5",
},
runtimeMode: "full-access",
});

assert.equal(harness.getLastCreateQueryInput()?.options.model, "claude-opus-4-8");
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("uses live settings for non-max Sonnet 5 effort and spawn options for max", () =>
Effect.gen(function* () {
for (const effort of ["low", "medium", "high", "xhigh", "max"] as const) {
Expand Down Expand Up @@ -4287,6 +4471,33 @@ describe("ClaudeAdapterLive", () => {
);
});

it.effect("preserves an Opus alias context suffix when changing models live", () => {
const harness = makeHarness({ claudeVersion: "2.1.219" });
return Effect.gen(function* () {
const adapter = yield* ClaudeAdapter;

const session = yield* adapter.startSession({
threadId: THREAD_ID,
provider: "claudeAgent",
runtimeMode: "full-access",
});
yield* adapter.sendTurn({
threadId: session.threadId,
input: "hello",
modelSelection: {
provider: "claudeAgent",
model: "opus[1m]",
},
attachments: [],
});

assert.deepEqual(harness.query.setModelCalls, ["claude-opus-5[1m]"]);
}).pipe(
Effect.provideService(Random.Random, makeDeterministicRandomService()),
Effect.provide(harness.layer),
);
});

it.effect("updates the auto-compact budget live without changing the Claude model id", () => {
const harness = makeHarness();
return Effect.gen(function* () {
Expand Down
Loading
Loading