Fixing the CI through 3 changes - #685
Merged
Merged
Conversation
trexfeathers
requested changes
Aug 18, 2026
trexfeathers
left a comment
Contributor
There was a problem hiding this comment.
Thanks @HGWright! Once change for you.
I've made the requested changes within cf-units PyPI so that's all ready to use.
HGWright
marked this pull request as ready for review
August 18, 2026 14:40
trexfeathers
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
0f01174 - updates the manylinux version ref python-stratify/#439
3193cc9 - update the MACOSX_DEPLOYMENT_TARGET to 26 as this is the minimum required by
cf-unitsdependencies18215d4 - added the config for trusted publishing, some config also needs to be done on the pypi and test-pypi pages for this package, and so this PR is blocked until those steps are completed. See docs for more details https://github.com/pypa/gh-action-pypi-publish#usage & https://docs.pypi.org/trusted-publishers/adding-a-publisher/