Avoid ambiguous generators in output saturation - #536
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Avoid ambiguous generators in output saturation#536ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Collaborator
|
Thanks! |
Collaborator
|
Note this is fixed in #522 . The fix there is replacing |
Collaborator
|
With this, the qualifier |
Collaborator
|
Fixed by #537 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
AbstractAlgebra0.50 added an exportedgeneratorsalias, whileRationalFunctionFieldsexports a differentgeneratorsbinding. Importing bothleaves the unqualified binding undefined in
StructuralIdentifiability, sosaturate_outputserrors when it callsgenerators(current_y).The dependency boundary was reproduced locally:
UndefVarError: generators not definedRationalFunctionFields 0.3.2 widened compatibility to the failing dependency
combination. Rather than relying on its undocumented
generatorshelper, thischange retains the exact generator vector already supplied to each field
constructor.
This also fixes the downstream failure exposed by
SciML/ModelingToolkit.jl#4845.
Local verification
RationalFunctionFields 0.3.3: focused rational-output regression returns two
outputs, including
z(t) // adownstream reproduction returns two saturated outputs
GROUP=Core julia +1.10 --startup-file=no --project=. -e 'using Pkg; Pkg.test()'GROUP=QA julia +1.10 --startup-file=no --project=. -e 'using Pkg; Pkg.test()'(17 passed, 1 pre-existing broken)