Fix symmetry factor calculation used modified function values after b… - #1128
Open
Proektsoft-EOOD wants to merge 1 commit into
Open
Fix symmetry factor calculation used modified function values after b…#1128Proektsoft-EOOD wants to merge 1 commit into
Proektsoft-EOOD wants to merge 1 commit into
Conversation
…isection fallback Updated the ModAB method implementation to use the original function values f1 and f2 for calculation of symmetry factor after bisection fallback instead of y1 and y2 that have been modified by A&B correction factors.
Contributor
Author
|
This fix has been proposed by Assoc. Prof. L. Tomov (algorithm co-author). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
After bisection fallback, the symmetry factor was calculated using y1 and y2 that have been modified by Anderson-Bjorck correction factors. Not this is fixed by storing the original (unmodified) function values f1 and f2 to be used for that purpose instead of y1 and y2.
Add any other context about the problem here.