Support monorepo package globs in downstream tests - #128
Merged
ChrisRackauckas merged 1 commit intoAug 20, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The reusable downstream workflow already defaults to Julia
1, but callers could only enumerate upstream package directories individually. This adds a trailing/*form toupstream-subdirsand develops the immediate child directories that contain aProject.toml.OrdinaryDiffEq can use
.,lib/*when it migrates its bespoke Julia-1.10 downstream job to this shared workflow. That addresses the ProbNumDiffEq resolver failure at the workflow layer requested in SciML/OrdinaryDiffEq.jl#4320.Ignore this PR until it has been reviewed by @ChrisRackauckas.
Verification
Failing before the workflow change, with the new assertions applied:
Passing after:
An isolated fixture containing a root project,
lib/A,lib/B, and a non-packagelib/not-a-packageresolved to:Also passed:
Not verified
I did not run an end-to-end reusable-workflow invocation on GitHub Actions locally. The follow-up OrdinaryDiffEq migration should remain blocked on this prerequisite.