feat: add support for scalingo-26#597
Conversation
EtienneM
force-pushed
the
feat/STORY-3771/scalingo-26
branch
from
e4dc31d to
c73ce92
Compare
| # PHP extensions versions | ||
| igbinary_version="3.2.16" | ||
| mongodb_version="1.21.0" | ||
| mongodb_version="2.3.3" |
There was a problem hiding this comment.
Compilation failed for any 1.21.x versions on scalingo-26 with the error:
In file included from /tmp/phpmongodb_GulD/mongodb-1.21.0/src/phongo_bson.c:24:
/tmp/phpmongodb_GulD/mongodb-1.21.0/src/contrib/php_array_api.h: In function 'php_array_zval_to_string':
/tmp/phpmongodb_GulD/mongodb-1.21.0/src/contrib/php_array_api.h:353:36: error: implicit declaration of function 'IS_INTERNED'; did you mean 'IS_STR_INTERNED'? [-Wimplicit-function-declaration]
353 | *pfree = ! IS_INTERNED(Z_STR(c));
| ^~~~~~~~~~~
| IS_STR_INTERNED
make: *** [Makefile:1020: src/phongo_bson.lo] Error 1
I updated to 2.3.3 and I uploaded version 2.3.3 for all PHP versions on all stacks.
There was a problem hiding this comment.
Mmh, issue with this is that 2.x comes with breaking changes, and we currently have no way to specify an extension version :-/
Seems like we'll have to:
- Ship 2.x with
scalingo-26 - Ship 1.x with
scalingo-24, and provide a way to specify an extension version quite soon.
There was a problem hiding this comment.
I kind of remember we had to work on this for the Redis extension. Don't we already have something in place to choose an extension for a version?
There was a problem hiding this comment.
Side note:
MongoDB 4.2+ Required: Future versions of the library will require MongoDB 4.2 or later. MongoDB 4.0 support is deprecated.
from https://github.com/mongodb/mongo-php-driver/releases/tag/2.0.0
And
support for MongoDB 4.0 has been removed
from https://github.com/mongodb/mongo-php-driver/releases/tag/2.1.0
Hence I need to stick with v2.0.0
There was a problem hiding this comment.
This was discussed here: https://scalingo.slack.com/archives/C08LD7JN22V/p1779442086765389
There was a problem hiding this comment.
This was discussed here: https://scalingo.slack.com/archives/C08LD7JN22V/p1779442086765389
2 participants
No description provided.