Skip to content

Create ja_jp.json for 26.1 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abbage230 wants to merge 1 commit into
base: 26.1
Choose a base branch
from
Open

Create ja_jp.json for 26.1 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/resources/assets/luminax/lang/ja_jp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"block.luminax.luminax_block": "Luminaxブロック",
"block.luminax.luminax_button": "Luminaxのボタン",
"block.luminax.luminax_pressure_plate": "Luminaxの感圧板",
"block.luminax.luminax_slab": "Luminaxのハーフブロック",
"block.luminax.luminax_stair": "Luminaxの階段",
"block.luminax.luminax_wall": "Luminaxの塀",
"creative_tab.luminax.default": "Luminax",
"item.luminax.luminax_wand": "Luminaxの杖",
"key.category.luminax.default": "Luminax",
"key.luminax.open_color_picker": "カラーピッカーを開く",
"key.luminax.toggle_glowing": "発光の切り替え",
"property.luminax.color": "色",
"property.luminax.color.tooltip": "ブロックの色を変更します",
"property.luminax.glowing": "発光",
"tooltip.luminax.glowing.off": "ブロックが光を発するようにします",
"tooltip.luminax.glowing.on": "ブロックが光を発するようにします",
Comment on lines +16 to +17

@coderabbitai coderabbitai Bot May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Identical tooltips for glowing on and off states.

Both tooltip.luminax.glowing.off and tooltip.luminax.glowing.on have the same translation: "ブロックが光を発するようにします" (Makes the block emit light). This appears to be inherited from the English source in LXLanguage.java, where both states also have identical text.

The .off tooltip should describe turning glowing off (e.g., "ブロックの発光を停止します" - Stops the block from emitting light), while the .on tooltip describes turning it on.

💡 Suggested fix for clarity 
- "tooltip.luminax.glowing.off": "ブロックが光を発するようにします",
+ "tooltip.luminax.glowing.off": "ブロックの発光を停止します",
  "tooltip.luminax.glowing.on": "ブロックが光を発するようにします",

As per context snippet from LXLanguage.java:17-49, the English source also has this inconsistency where both TOOLTIP_GLOWING_ON and TOOLTIP_GLOWING_OFF use "Makes the block emit light".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"tooltip.luminax.glowing.off": "ブロックが光を発するようにします",
"tooltip.luminax.glowing.on": "ブロックが光を発するようにします",
"tooltip.luminax.glowing.off": "ブロックの発光を停止します",
"tooltip.luminax.glowing.on": "ブロックが光を発するようにします",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/resources/assets/luminax/lang/ja_jp.json` around lines 16 - 17, The
two Japanese tooltip entries tooltip.luminax.glowing.on and
tooltip.luminax.glowing.off are identical; update the .off entry to clearly
indicate disabling glowing (e.g., change tooltip.luminax.glowing.off to
"ブロックの発光を停止します") while keeping tooltip.luminax.glowing.on as the enabling
message ("ブロックが光を発するようにします"); this mirrors the intended pair TOOLTIP_GLOWING_ON
/ TOOLTIP_GLOWING_OFF used in LXLanguage.java.

"tooltip.luminax.lmb": "%sまたは%sで順方向に切り替え",
"tooltip.luminax.mmb": "%sでカラーピッカーを開く",
"tooltip.luminax.rmb": "%sまたは%sで逆方向に切り替え"
}