fix: use caching to fetch role id#4
Open
Samk13 wants to merge 1 commit into
Open
Conversation
* Refactor role retrieval to use resolve_role_id for consistency and clarity.
Samk13
force-pushed
the
test-cache-from-acounts-utils-pr
branch
from
February 20, 2026 14:50
b6d7c92 to
0ecab4d
Compare
max-moser
reviewed
Mar 16, 2026
| from invenio_communities.permissions import CommunityPermissionPolicy | ||
| from invenio_records_permissions.generators import Disable, Generator, SystemProcess | ||
| from invenio_accounts.proxies import current_datastore | ||
| from invenio_accounts.utils import resolve_role_id |
There was a problem hiding this comment.
Does this require a PR for Invenio-Accounts?
I cannot find resolve_role_id in invenio_accounts.utils 👀
Owner
Author
There was a problem hiding this comment.
You are right! It's still a PR: inveniosoftware/invenio-accounts#548
Samk13
force-pushed
the
master
branch
2 times, most recently
from
June 10, 2026 13:24
950eac1 to
5dbf487
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: