Skip to content

fix: handle chapter display and nibbles for late-start playback #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Roze061 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: handle chapter display and nibbles for late-start playback #765

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bdb7404
Refactor chapter visibility for late start chapter
Roze061 May 31, 2026
83c8d44
Fix nil check for chapter_list in collect_gap_cuts
Roze061 May 31, 2026
2b24f97
Use markers variable instead of state.chapter_list directly
Roze061 May 31, 2026
9404fdf
chapter: use request_init instead of #chapter_list
Roze061 Jun 4, 2026
2d76a8e
Merge branch 'Samillion:main' into late-chapter
Roze061 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions modernz.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,7 +1345,8 @@ local function collect_gap_cuts(element)
local cuts = {}
if element.slider.markerF then
for n, marker in ipairs(element.slider.markerF()) do
if n > 1 and marker >= element.slider.min.value and marker <= element.slider.max.value then
local sk = n > 1 or (n == 1 and marker > 0)
if sk and marker >= element.slider.min.value and marker <= element.slider.max.value then
cuts[#cuts + 1] = get_slider_ele_pos_for(element, marker)
end
end
Expand Down Expand Up @@ -1513,7 +1514,8 @@ local function draw_seekbar_nibbles(element, elem_ass)
-- draw non-current chapter nibbles
local has_non_current = false
for n, marker in ipairs(markers) do
if n > 1 and (n - 1) ~= current_chapter and marker >= element.slider.min.value and marker <= element.slider.max.value then
local sk = n > 1 or (n == 1 and marker > 0)
if sk and (n - 1) ~= current_chapter and marker >= element.slider.min.value and marker <= element.slider.max.value then
if not has_non_current then
begin_draw_layer(element, elem_ass, user_opts.nibble_color)
has_non_current = true
Expand All @@ -1523,7 +1525,7 @@ local function draw_seekbar_nibbles(element, elem_ass)
end

-- draw current chapter nibble on top
if current_chapter > 0 and current_chapter < #markers then
if (current_chapter > 0 or (current_chapter == 0 and markers[1] > 0)) and current_chapter < #markers then
local marker = markers[current_chapter + 1]
if marker >= element.slider.min.value and marker <= element.slider.max.value then
begin_draw_layer(element, elem_ass, user_opts.nibble_current_color)
Expand Down Expand Up @@ -4227,7 +4229,7 @@ observe_cached("mute", request_tick)
observe_cached("eof-reached", request_tick)
observe_cached("ontop", request_init)
observe_cached("speed", request_tick)
observe_cached("chapter", request_tick)
observe_cached("chapter", request_init)
-- ensure compatibility with auto loop scripts
mp.observe_property("loop-file", "bool", function(_, val)
state.file_loop = (val ~= false)
Expand Down