Fix merge conflict: Do not stop player-forced jobs when curPath is recalculated - #1
Merged
Merged
Conversation
Co-authored-by: SaintWacko <10342141+SaintWacko@users.noreply.github.com>
Copilot
AI
changed the title
Do not stop player-forced jobs when curPath is recalculated
Fix merge conflict: Do not stop player-forced jobs when curPath is recalculated
Aug 23, 2026
Copilot created this pull request from a session on behalf of
SaintWacko
August 23, 2026 02:57
View session
Co-authored-by: SaintWacko <10342141+SaintWacko@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The new interaction/camera changes introduce concrete runtime/UX risks (null letter text usage and camera target mismatch) that should be fixed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR resolves merge-related behavior changes in the mod by updating avatar movement/camera handling and expanding interaction/settings support (including the upstream “disable double-click to equip” option), while adding the required localization keys.
Changes:
- Adds a new mod setting to disable the “double-click to wear/equip” shortcut and wires it into the interaction flow.
- Adds an interaction handler to capture eligible carried pawns/entities into a holding platform (CompEntityHolder / CompHoldingPlatformTarget).
- Adjusts avatar camera targeting fallback behavior and updates English localization keys for new UI/messages.
File summaries
| File | Description |
|---|---|
| Languages/English/Keyed/Keys.xml | Adds new localized strings for the new setting and holding-platform capture feedback. |
| 1.6/Source/PerspectiveShiftSettings.cs | Introduces a persisted disableDoubleClickEquip setting. |
| 1.6/Source/PerspectiveShiftMod.cs | Exposes the new setting in the mod settings UI. |
| 1.6/Source/Avatar/Avatar_Movement.cs | Updates camera fallback position calculation during camera updates. |
| 1.6/Source/Avatar/Avatar_Interaction.cs | Adds double-click equip gating + new holding-platform capture interaction. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fence crossings trigger two
curPathrecalculations, causingstopDead()to interrupt player-forced jobs (e.g., eating). Fix adds aplayerForcedguard and uses null-conditional operators to tighten the path checks.Changes
Avatar_Movement.cs— Two call sites updated:PerspectiveShift.dll— Binary conflict resolved by taking the upstream version (includes the "disable double-click to equip" mod option fromfernyrepos/main).